Skip to content

Commit f3a65e3

Browse files
committed
Update README.md
Requirement on the torchvision variant was not documented. The OCI image tag can not have +, so it was attempted in vain.
1 parent 7404b1f commit f3a65e3

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
# Tags have limited set of valid character, '+' not included
6363
# https://github.com/opencontainers/distribution-spec/blob/main/spec.md#pulling-manifests
6464
run: |
65-
echo "tag=$(echo -n "${{ matrix.torch }}${{ matrix.index && format('+{0}', matrix.index) || '' }}-${{ matrix.python }}" | tr -c 'a-zA-Z0-9._-' '[-*]')" >> $GITHUB_OUTPUT
65+
echo "tag=$(echo -n "${{ matrix.torch }}${{ matrix.index && format('-{0}', matrix.index) || '' }}-${{ matrix.python }}" | tr -c 'a-zA-Z0-9._-' '[-*]')" >> $GITHUB_OUTPUT
6666
6767
- uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 # v6.18.0
6868
with:

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ packages. To know the packages already installed, run
1616

1717
The output can be used as content of `--constraint` file to `pip-compile`.
1818

19+
The torch builds for +cuNNN are installed from package index
20+
<https://download.pytorch.org/whl/cuNNN/>. This same index needs to be used to
21+
install `torchvision`. It is not included in the image because it is fairly
22+
small and has dependencies we rather maintain in the images build on this.
23+
1924
# License
2025

2126
The image build is licensed using BSD-3, but the underlying Debian, Python,

0 commit comments

Comments
 (0)