OKTA-1177141 Add Edit existing 3p action in OIN Wizard#6219
Open
vanngo-okta wants to merge 20 commits into
Open
OKTA-1177141 Add Edit existing 3p action in OIN Wizard#6219vanngo-okta wants to merge 20 commits into
vanngo-okta wants to merge 20 commits into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
vanngo-okta
force-pushed
the
vn-okta-1177141-actions-oin-update
branch
from
8c59174 to
2e896bb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
vanngo-okta
force-pushed
the
vn-okta-1177141-actions-oin-update
branch
from
2e896bb to
ac76f45
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
vanngo-okta
requested review from
barbaravo-okta,
brentschaus-okta,
emikhasyak-okta,
grahamsmith-okta,
ishan-krishna-okta,
janethu-okta,
paulwallace-okta and
susanharper-okta
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
divyabhushan-okta
left a comment
divyabhushan-okta
left a comment
Contributor
There was a problem hiding this comment.
Hi @van - The PR looks good.
I just found a nit "backward" compatibility consistency and worth adding a note to clarify the integration types (SSO) the OIN Wizard auto-detects and for SCIM and 3p actions, the Wizard doesn't detect previously created instances.
I commented on the PR. Thank you!
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
…them for consistency
vanngo-okta
force-pushed
the
vn-okta-1177141-actions-oin-update
branch
from
b9354f4 to
5507863
Compare
Acrolinx scoreA minimum Acrolinx Score of 80 is required. The total score is an average of the subscores.
Successfully checked 33 of 33 documents. Reopen the pull request or push new changes to check again. Depending on the Acrolinx server configuration, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Resolves:
Netlify Preview Link:
Preview