Refactor RecordingBlock and RecordingFrame for clarity and consistency in property naming and initialization.

Author: voytas

src/Spectron.Files/Rzx/Blocks/RecordingBlock.cs

@@ -26,8 +26,11 @@ public class RecordingBlock
     /// <summary>
     /// Flags (b0: Protected (frames are encrypted with x-key), b1: Compressed data.)
     /// </summary>
-    public DWord Flags { get; private set; }
+    public DWord Flags { get; private init; }
 
+    /// <summary>
+    /// Sequence of input frames.
+    /// </summary>
     public List<RecordingFrame> Frames { get; } = [];
 
     internal static RecordingBlock Read(ByteStreamReader reader, DWord blockLength)
@@ -70,8 +73,8 @@ private static void ReadFrames(RecordingBlock block, byte[] data)
 
             if (frame.InCounter == 65535)
             {
-                // Repeated frame, copy the values from the previous frame
-                frame.Values = block.Frames.LastOrDefault()?.Values ?? [];
+                // Repeated frame, copy "in" values from the previous frame
+                frame.InValues = block.Frames.LastOrDefault()?.InValues ?? [];
             }
 
             block.Frames.Add(frame);

src/Spectron.Files/Rzx/Blocks/RecordingFrame.cs

@@ -21,7 +21,7 @@ public class RecordingFrame
     /// <summary>
     /// Return values for the CPU I/O port reads.
     /// </summary>
-    public byte[] Values { get; internal set; } = [];
+    public byte[] InValues { get; internal set; } = [];
 
     internal static RecordingFrame Read(ByteStreamReader reader)
     {
@@ -33,7 +33,7 @@ internal static RecordingFrame Read(ByteStreamReader reader)
 
         if (block.InCounter != 65535)
         {
-            block.Values = reader.ReadBytes(block.InCounter);
+            block.InValues = reader.ReadBytes(block.InCounter);
         }
 
         return block;

src/Spectron.Files/Rzx/Blocks/SnapshotBlock.cs

@@ -27,7 +27,7 @@ public class SnapshotBlock
     /// <summary>
     /// Input recording block.
     /// </summary>
-    public RecordingBlock? Recording { get; internal set; }
+    public RecordingBlock Recording { get; internal set; } = new();
 
     /// <summary>
     /// Snapshot data.