feat(chat): add ACP show_model_choices setting#3020
Open
petobens wants to merge 1 commit intoolimorris:mainfrom
Open
feat(chat): add ACP show_model_choices setting#3020petobens wants to merge 1 commit intoolimorris:mainfrom
show_model_choices setting#3020petobens wants to merge 1 commit intoolimorris:mainfrom
Conversation
Make ACP adapter model selection consistent with the HTTP adapter setting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
show_model_choicesoption to ACP adapters and updatesadapter switching to respect that setting when listing ACP models.
This change makes ACP behavior consistent with HTTP adapters, which already
support
show_model_choices. It gives users a simple way to hide modelselection when changing adapters and keep the default model instead.
AI Usage
opus 4.6 with claude_code ACP adapter
Related Issue(s)
Screenshots
Checklist
make allto ensure docs are generated, tests pass and StyLua has formatted the code