Remove RNG.

Author: veluca93

pixie-uefi/Cargo.lock

@@ -23,8 +23,6 @@ lz4_flex = { version = "0.11.5", default-features = false }
 managed = { version = "0.8.0", default-features = false, features = ["alloc"] }
 minicov = { version = "0.3.7", optional = true }
 postcard = { version = "1.1.3", default-features = false, features = ["alloc"] }
-rand = { version = "0.8.5", default-features = false }
-rand_xoshiro = { version = "0.6.0", default-features = false }
 smoltcp = { version = "0.12.0", default-features = false, features = ["alloc", "proto-ipv4", "medium-ethernet", "socket-udp", "socket-tcp", "socket-dhcpv4", "async", "socket-tcp-cubic"] }
 thingbuf = { version = "0.1.6", default-features = false, features = ["alloc"] }
 uefi = { version = "0.33.0", features = ["alloc", "global_allocator", "panic_handler"] }

pixie-uefi/Cargo.toml

@@ -4,7 +4,6 @@ use self::{
     error::{Error, Result},
     executor::{Executor, Task},
     net::NetworkInterface,
-    rng::Rng,
     sync::SyncRefCell,
     timer::Timer,
 };
@@ -49,14 +48,12 @@ pub mod disk;
 pub mod error;
 mod executor;
 mod net;
-mod rng;
 mod sync;
 mod timer;
 
 pub use net::{TcpStream, UdpHandle, PACKET_SIZE};
 
 struct UefiOSImpl {
-    rng: Rng,
     tasks: Vec<Arc<Task>>,
     input: ScopedProtocol<Input>,
     vga: ScopedProtocol<Output>,
@@ -162,7 +159,6 @@ impl UefiOS {
         }
 
         Timer::ensure_init();
-        let rng = Rng::new();
 
         let input_handles = uefi::boot::find_handles::<Input>().unwrap();
         let input = uefi::boot::open_protocol_exclusive::<Input>(input_handles[0]).unwrap();
@@ -177,7 +173,6 @@ impl UefiOS {
         vga.clear().unwrap();
 
         *OS.borrow_mut() = Some(UefiOSImpl {
-            rng,
             tasks: Vec::new(),
             input,
             vga,
@@ -270,10 +265,6 @@ impl UefiOS {
         RefMut::map(OS.borrow_mut(), |f| f.as_mut().unwrap())
     }
 
-    pub fn rng(&self) -> RefMut<'static, Rng> {
-        RefMut::map(self.borrow_mut(), |f| &mut f.rng)
-    }
-
     fn tasks(&self) -> RefMut<'static, Vec<Arc<Task>>> {
         RefMut::map(self.borrow_mut(), |f| &mut f.tasks)
     }

pixie-uefi/src/os/mod.rs

@@ -1,3 +1,5 @@
+use crate::os::timer::rdtsc;
+
 use super::{
     error::{Error, Result},
     timer::Timer,
@@ -182,7 +184,7 @@ impl NetworkInterface {
         ));
 
         let mut interface_config = Config::new(hw_addr);
-        interface_config.random_seed = os.rng().rand_u64();
+        interface_config.random_seed = rdtsc() as u64;
         let now = Timer::instant();
         let interface = Interface::new(interface_config, &mut device, now);
         let mut dhcp_socket = Dhcpv4Socket::new();
@@ -198,7 +200,7 @@ impl NetworkInterface {
             dhcp_socket_handle,
             device,
             socket_set,
-            ephemeral_port_counter: os.rng().rand_u64(),
+            ephemeral_port_counter: 0,
             rx: 0,
             tx: 0,
             vrx: 0,

pixie-uefi/src/os/net.rs

@@ -10,7 +10,7 @@ static INITIALIZED: AtomicBool = AtomicBool::new(false);
 
 pub struct Timer {}
 
-fn rdtsc() -> i64 {
+pub(super) fn rdtsc() -> i64 {
     // SAFETY: modern x86 CPUs have this instruction.
     unsafe { _rdtsc() as i64 }
 }