Add support for multiple interfaces#102
Merged
Merged
Conversation
eliasol
force-pushed
the
multiple-ifaces
branch
3 times, most recently
from
November 29, 2025 16:05
35f3c35 to
681b553
Compare
eliasol
force-pushed
the
multiple-ifaces
branch
from
November 29, 2025 16:15
681b553 to
ec1b3de
Compare
Virv12
requested changes
Nov 29, 2025
Virv12
requested changes
Nov 29, 2025
| .iter() | ||
| .map(|iface| { | ||
| let (tx, rx) = mpsc::channel(128); | ||
| ((iface.network, tx), (iface.network, rx)) |
Member
There was a problem hiding this comment.
Suggested change
| ((iface.network, tx), (iface.network, rx)) | |
| ((iface.network, tx), (iface, rx)) |
Comment on lines
+242
to
+244
| for (network, rx) in net_rx { | ||
| tasks.push(broadcast_chunks(&state, &socket, network.broadcast(), rx).boxed()); | ||
| tasks.push(broadcast_hint(&state, &socket, network.broadcast()).boxed()); |
Member
There was a problem hiding this comment.
Suggested change
| for (network, rx) in net_rx { | |
| tasks.push(broadcast_chunks(&state, &socket, network.broadcast(), rx).boxed()); | |
| tasks.push(broadcast_hint(&state, &socket, network.broadcast()).boxed()); | |
| for (iface, rx) in net_rx { | |
| tasks.push(broadcast_chunks(&state, &socket, iface, rx).boxed()); | |
| tasks.push(broadcast_hint(&state, &socket, iface.network.broadcast()).boxed()); |
Member
There was a problem hiding this comment.
Then broadcast_chunks takes an InterfaceConfig and does not need to find its broadcast_speed
eliasol
force-pushed
the
multiple-ifaces
branch
2 times, most recently
from
November 29, 2025 17:22
fa4399b to
dc406b3
Compare
eliasol
force-pushed
the
multiple-ifaces
branch
from
November 29, 2025 17:36
dc406b3 to
5fc184e
Compare
Virv12
approved these changes
Nov 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.