Set TM_DATA_DIR in release.yml#351
Conversation
veluca93
force-pushed
the
veluca93-patch-1
branch
from
c3d28de to
d56c62d
Compare
Sure. While I was at it, i also got rid of double zipping on the artifacts uploaded to each workflow run. |
| with: | ||
| name: tmr-debs-${{ env.ARTIFACT_SUFFIX }} | ||
| path: tmr-debs-${{ env.ARTIFACT_SUFFIX }}.tar.gz | ||
| path: "target/debian/*.deb" |
There was a problem hiding this comment.
Do those files have unique names? I see above that they are for some reason compressed into a tar.gz, but why so?
I'd rename the deb into something with ARTIFACT_SUFFIX, avoid compressing them, and upload the renamed .deb file. What do you think, @veluca93?
There was a problem hiding this comment.
There is no reason for them to be compressed in a tar.gz, upload-artifact already creates a zip file (this is some gh action code I copied from libjxl). I also believe it's hard to upload non-zipped artefacts to CI outcomes, but I am not super sure.
However, I see that the name collisions is causing issues for releases... I will check how to rename the debian files.
2 participants
No description provided.