Skip to content

Set TM_DATA_DIR in release.yml #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veluca93 merged 1 commit into from
Sep 6, 2025
Merged

Set TM_DATA_DIR in release.yml #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ jobs:
- debian:trixie
container:
image: ${{ matrix.os }}
env:
TM_DATA_DIR: /usr/share/task-maker-rust
steps:
- uses: actions/checkout@v4
- name: Install Deps
Expand Down Expand Up @@ -60,9 +62,16 @@ jobs:
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2
with:
name: tmr-debs-${{ env.ARTIFACT_SUFFIX }}
path: tmr-debs-${{ env.ARTIFACT_SUFFIX }}.tar.gz
path: "target/debian/*.deb"

@edomora97 edomora97 Sep 6, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do those files have unique names? I see above that they are for some reason compressed into a tar.gz, but why so?

I'd rename the deb into something with ARTIFACT_SUFFIX, avoid compressing them, and upload the renamed .deb file. What do you think, @veluca93?

@veluca93 veluca93 Sep 6, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no reason for them to be compressed in a tar.gz, upload-artifact already creates a zip file (this is some gh action code I copied from libjxl). I also believe it's hard to upload non-zipped artefacts to CI outcomes, but I am not super sure.

However, I see that the name collisions is causing issues for releases... I will check how to rename the debian files.

compression-level: 0

- name: Upload the artifacts
uses: skx/github-action-publish-binaries@master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
args: "target/debian/*.deb"

aur:
name: AUR
runs-on: ubuntu-latest
Expand Down