Skip to content

[CRASH] When ripple deleting in certain circumstances #2233

@jazztickets

Description

@jazztickets

Commit Hash
70690c5

Platform
Arch Linux

Summary
I've found that when ripple deleting a few clips (possibly involving cross fades or text nodes), olive crashes.

Steps to Reproduce

  1. Create a few clips on the timeline, and add text nodes and/or crossfades between them
  2. Highlight some of the clips at the beginning, but not all clips
  3. Shift+delete to ripple delete.

Here's one scenario that crashes:
2023-05-31_20-21

Crash Report


Additional Information

I loaded up Olive in a debugger and it turns out the track variable is null on line 390:

Track *track = region.first;

Adding something like this fixes the crashes:

    Track *track = region.first;
    if(!track) {
      qWarning() << "Track is null!";
      continue;
    }

If it's not supposed to be null, then we got other problems but it's a good idea to check for null here in any case.

Metadata

Metadata

Assignees

No one assigned

    Labels

    CrashUnexpected termination or freeze of OliveTriageThis issue is yet to be triaged

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions