Add "generic" to the list of supported parameter types#516
Open
GCHQDeveloper137 wants to merge 1 commit into
Open
Add "generic" to the list of supported parameter types#516GCHQDeveloper137 wants to merge 1 commit into
GCHQDeveloper137 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like the code to handle this is already present, as with this in place it generates the correct TCL to set the generics.
Without this change, FuseSoC cores using
flow: vivadowill print a warning for a each generic parameter for a given taget, and if an attempt is make to set that generic on the command line, the build will fail. With this change, the warnings are gone and CLI options to set generics are accepted and transformed into correct TCL, resulting in Vivado working as expected.Fixes issue #515