flows/vpr: fix 'ftdo' typo to 'fdto'#519
Open
ThVerg wants to merge 1 commit into
Open
Conversation
The 'ftdo' key was silently ignored by Edaflow because it only recognises 'fdto' (flow-defined tool options), so yosys was never told to emit BLIF output for the VPR flow.
ThVerg
added a commit
to ThVerg/edalize
that referenced
this pull request
May 12, 2026
Codex pointed out that FlowGraph.fromdict(d: dict[str, Any]) was loose
enough to let the 'ftdo' misspelling in flows/vpr.py slip past static
checks. Add a FlowNodeSpec TypedDict modelling the {deps, fdto, tool}
keys and narrow:
* FlowGraph.fromdict signature
* the _flow class attribute on apicula / icestorm / trellis
* the local flow dict in apicula, generic, gls, icestorm, trellis,
vivado, vpr
Apply the 'ftdo' -> 'fdto' fix in flows/vpr.py to match the standalone
upstream PR olofk#519 so this branch type-checks; will rebase cleanly once
the upstream PR lands.
mypy: 0 errors
pytest: 474 passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ftdokey inflows/vpr.py's yosys flow node is silently dropped becauseEdaflowonly recognisesfdto(flow-defined tool options). As a result yosys is never told to emit BLIF output for the VPR flow.One-character fix.