tools/sandpipersaas: pass dependency list to commands.add, not a string#520
Open
ThVerg wants to merge 1 commit into
Open
tools/sandpipersaas: pass dependency list to commands.add, not a string#520ThVerg wants to merge 1 commit into
ThVerg wants to merge 1 commit into
Conversation
The 'clean' target was being registered with depends=" " (a string), but EdaCommands.add expects a list of dependency names.
ThVerg
added a commit
to ThVerg/edalize
that referenced
this pull request
May 13, 2026
* Remove allow_redefinition = true from the project mypy config. It
was masking real strict-mode errors in edatool.py and tools/vpr.py.
Fixed the three uncovered redefinitions explicitly:
- edatool.parse_args: annotate the parse_args 'default' local as Any.
- tools/vpr.setup: type 'depends' as str | list[str], assert before
passing as a single dep.
- ise_reporting._parse_twr_stats: annotate pp_units as
pp.ParserElement so the | reassignment widens cleanly.
* Restore Node(__init__) positional ordering to pristine
(name, deps=[], fdto={}, tool=None) so positional callers don't break.
Validate tool with an assert inside the body; pristine crashes on
None at .capitalize() anyway, this gives a clearer message.
* Apply the sandpipersaas depends=[] fix locally (mirrors PR olofk#520) and
drop the silenced type:ignore.
* Apply the flows/vpr.py build_tool_graph dead-method removal locally
(the local-only branch that I held back at the user's request) and
drop the silenced type:ignore.
mypy: 0 errors
mypy --strict on the four strict modules: 0 errors
pytest: 474 passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cleantarget was registered withdepends=" "(a single-space string).EdaCommands.addexpects a list of dependency names; the string is wrong and was never intentional.