tools/vivado: return local args from build(), not undefined self.args#522
Open
ThVerg wants to merge 1 commit into
Open
tools/vivado: return local args from build(), not undefined self.args#522ThVerg wants to merge 1 commit into
ThVerg wants to merge 1 commit into
Conversation
build() builds up a local 'args' list but returned 'self.args', which was never assigned. The intent was clearly to return the local list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vivado.build()builds up a localargslist but returnsself.args, which is never assigned anywhere on the class. The fix is to return the localargsthat was just constructed.