openfpga: forward eda_api and verbose to base ctor correctly#524
Open
ThVerg wants to merge 1 commit into
Open
Conversation
The third positional argument of Edatool.__init__ is eda_api, not verbose. Openfpga.__init__ was passing 'verbose' into the eda_api slot, so verbose was silently stored as the EDAM dict and the actual verbose flag was dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edatool.__init__takes(edam, work_root, eda_api, verbose).Openfpga.__init__was callingsuper().__init__(edam, work_root, verbose), which assignsverboseinto theeda_apislot and drops the realverboseflag entirely.