Move rules to separate files

Author: olsh

README.md

@@ -9,105 +9,12 @@
 
 A Roslyn-based analyzer for SQL related stuff in .NET
 
-
 ## Analyzers
 
-### SQL001
-**SQL type is not specified**
-
-Noncompliant Code Example:  
-```csharp
-Query<Thing>("select * from Thing where Name = @Name", new { Name = abcde });
-```
-
-Compliant Solution:  
-```csharp
-Query<Thing>("select * from Thing where Name = @Name", new {Name = new DbString { Value = "abcde", IsFixedLength = true, Length = 10, IsAnsi = true }});
-```
-
-https://github.com/StackExchange/Dapper/blob/master/Readme.md#ansi-strings-and-varchar
-
-
-### SQL002
-**SQL parameters mismatch**
-
-Noncompliant Code Example:  
-Dapper
-```csharp
-var dog = connection.Query<Dog>("select Age = @Age, Id = @Id", new { Id = guid });
-```
-
-SqlCommand
-```csharp
-var sql = new SqlCommand("select Age = @Age, Id = @Id");
-sql.Parameters.AddWithValue("@Id", guid);
-sql.ExecuteNonQuery();
-```
-
-Compliant Solution:  
-Dapper
-```csharp
-var dog = connection.Query<Dog>("select Age = @Age, Id = @Id", new { Age = (int?)null, Id = guid });
-```
-
-SqlCommand
-```csharp
-var sql = new SqlCommand("select Age = @Age, Id = @Id");
-sql.Parameters.AddWithValue("@Id", guid);
-sql.Parameters.AddWithValue("@Age", 42);
-sql.ExecuteNonQuery();
-```
-
-### SQL003
-**Using 'Query' method is not optimal here**
-
-Noncompliant Code Example:  
-```csharp
-var dog = connection.Query<Dog>("select * from dogs").Single();
-```
-
-Compliant Solution:  
-```csharp
-var dog = connection.QuerySingle<Dog>("select * from dogs");
-```
-
-https://github.com/StackExchange/Dapper#performance
-
-### SQL004
-**Using 'QueryMultiple' method is not optimal here**
-
-Noncompliant Code Example:  
-```csharp
-var multi = connection.QueryMultiple("select * from dogs");
-var dogs = multi.Read<Dog>();
-```
-
-Compliant Solution:  
-```csharp
-var dogs = connection.Query<Dog>("select * from dogs");
-```
-
-### SQL005
-
-**Using 'SaveChanges' method in a loop can affect performance**
-
-Noncompliant Code Example:  
-```csharp
-var dbContext = new DbContext("test");
-for (int i = 0; i < 100; i++)
-{
-    dbContext.Entities.Add(new Entity(i));
-    s.SaveChanges();
-}
-```
-
-Compliant Solution:  
-```csharp
-var dbContext = new DbContext("test");
-for (int i = 0; i < 100; i++)
-{
-    dbContext.Entities.Add(new Entity(i));
-}
-
-s.SaveChanges();
-```
+| Rule\Library                                                                           |       Dapper       |       ADO.NET      |  Entity Framework  |
+|----------------------------------------------------------------------------------------|:------------------:|:------------------:|:------------------:|
+| [SQL001: SQL type is not specified](rules/SQL001.md)                                   | :heavy_check_mark: |                    |                    |
+| [SQL002: SQL parameters mismatch](rules/SQL002.md)                                     | :heavy_check_mark: | :heavy_check_mark: |                    |
+| [SQL003: Using 'Query' method is not optimal here](rules/SQL003.md)                    | :heavy_check_mark: |                    |                    |
+| [SQL004: Using 'QueryMultiple' method is not optimal here](rules/SQL004.md)            | :heavy_check_mark: |                    |                    |
+| [SQL005: Using 'SaveChanges' method in a loop can affect performance](rules/SQL005.md) |                    |                    | :heavy_check_mark: |

rules/SQL001.md

@@ -0,0 +1,14 @@
+### SQL001
+**SQL type is not specified**
+
+Noncompliant Code Example:  
+```csharp
+Query<Thing>("select * from Thing where Name = @Name", new { Name = abcde });
+```
+
+Compliant Solution:  
+```csharp
+Query<Thing>("select * from Thing where Name = @Name", new {Name = new DbString { Value = "abcde", IsFixedLength = true, Length = 10, IsAnsi = true }});
+```
+
+https://github.com/StackExchange/Dapper/blob/master/Readme.md#ansi-strings-and-varchar

rules/SQL002.md

@@ -0,0 +1,29 @@
+### SQL002
+**SQL parameters mismatch**
+
+Noncompliant Code Example:  
+Dapper
+```csharp
+var dog = connection.Query<Dog>("select Age = @Age, Id = @Id", new { Id = guid });
+```
+
+SqlCommand
+```csharp
+var sql = new SqlCommand("select Age = @Age, Id = @Id");
+sql.Parameters.AddWithValue("@Id", guid);
+sql.ExecuteNonQuery();
+```
+
+Compliant Solution:  
+Dapper
+```csharp
+var dog = connection.Query<Dog>("select Age = @Age, Id = @Id", new { Age = (int?)null, Id = guid });
+```
+
+SqlCommand
+```csharp
+var sql = new SqlCommand("select Age = @Age, Id = @Id");
+sql.Parameters.AddWithValue("@Id", guid);
+sql.Parameters.AddWithValue("@Age", 42);
+sql.ExecuteNonQuery();
+```

rules/SQL003.md

@@ -0,0 +1,14 @@
+### SQL003
+**Using 'Query' method is not optimal here**
+
+Noncompliant Code Example:  
+```csharp
+var dog = connection.Query<Dog>("select * from dogs").Single();
+```
+
+Compliant Solution:  
+```csharp
+var dog = connection.QuerySingle<Dog>("select * from dogs");
+```
+
+https://github.com/StackExchange/Dapper#performance

rules/SQL004.md

@@ -0,0 +1,13 @@
+### SQL004
+**Using 'QueryMultiple' method is not optimal here**
+
+Noncompliant Code Example:  
+```csharp
+var multi = connection.QueryMultiple("select * from dogs");
+var dogs = multi.Read<Dog>();
+```
+
+Compliant Solution:  
+```csharp
+var dogs = connection.Query<Dog>("select * from dogs");
+```

rules/SQL005.md

@@ -0,0 +1,24 @@
+### SQL005
+
+**Using 'SaveChanges' method in a loop can affect performance**
+
+Noncompliant Code Example:  
+```csharp
+var dbContext = new DbContext("test");
+for (int i = 0; i < 100; i++)
+{
+    dbContext.Entities.Add(new Entity(i));
+    s.SaveChanges();
+}
+```
+
+Compliant Solution:  
+```csharp
+var dbContext = new DbContext("test");
+for (int i = 0; i < 100; i++)
+{
+    dbContext.Entities.Add(new Entity(i));
+}
+
+s.SaveChanges();
+```

src/SqlAnalyzer.Net/DapperQueryMisuseAnalyzer.cs

@@ -33,7 +33,7 @@ public class DapperQueryMisuseAnalyzer : DiagnosticAnalyzer
             DiagnosticSeverity.Warning,
             true,
             Description,
-            "https://github.com/olsh/sql-analyzer-net#sql003");
+            "https://github.com/olsh/sql-analyzer-net/rules/SQL003.md");
 
         private static readonly Regex DapperQueryRegex = new Regex(
             @"^(?<MethodPrefix>Query|Read).*",

src/SqlAnalyzer.Net/DapperQueryMultipleMisuseAnalyzer.cs

@@ -32,7 +32,7 @@ public class DapperQueryMultipleMisuseAnalyzer : DiagnosticAnalyzer
             DiagnosticSeverity.Warning,
             true,
             Description,
-            "https://github.com/olsh/sql-analyzer-net#sql004");
+            "https://github.com/olsh/sql-analyzer-net/rules/SQL004.md");
 
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);
 

src/SqlAnalyzer.Net/DapperStringParameterAnalyzer.cs

@@ -30,7 +30,7 @@ public class DapperStringParameterAnalyzer : DiagnosticAnalyzer
             DiagnosticSeverity.Warning,
             true,
             Description,
-            "https://github.com/olsh/sql-analyzer-net#sql001");
+            "https://github.com/olsh/sql-analyzer-net/rules/SQL001.md");
 
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);
 

src/SqlAnalyzer.Net/EntityFrameworkSaveChangesInLoopAnalyzer.cs

@@ -31,7 +31,7 @@ public class EntityFrameworkSaveChangesInLoopAnalyzer : DiagnosticAnalyzer
             DiagnosticSeverity.Warning,
             true,
             Description,
-            "https://github.com/olsh/sql-analyzer-net#sql005");
+            "https://github.com/olsh/sql-analyzer-net/rules/SQL005.md");
 
         public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create(Rule);