Created the docker file and the docker-compose file#24
Open
Naman9761 wants to merge 4 commits into
Open
Conversation
Create the docker file to make the OmAgent not dependent of any particular os or any particular version of any liberary.
Created Dockerfile
Created the docker-compose file to build the docker container and run the app in the machine
Create docker-compose.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
Created the docker file and the docker-compose.yml file
The docker would make it easy for a developer to set up the app on his machine and make the app independent of any OS. Moreover, it will also help the contributor focus more on the contribution to the repo rather than spending more time setting up the repo in his/her system and resolving the libraries and dependencies conflicts.
If these changes got merged then I would also like to add the changes in the readme file according to docker files as if anyone want to go with the docker setup thing then it would be easier for them.