Skip to content

Commit b8e6189

Browse files
committed
fix: clean RN config and document pod install
1 parent 77cabc0 commit b8e6189

4 files changed

Lines changed: 14 additions & 3 deletions

File tree

.github/workflows/publish.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,16 @@ jobs:
2727
scope: '@omarsdev'
2828
cache: 'yarn'
2929

30+
- name: Write npmrc for GitHub Packages
31+
run: |
32+
cat <<'EOF' > .npmrc
33+
@omarsdev:registry=https://npm.pkg.github.com
34+
//npm.pkg.github.com/:_authToken=${NODE_AUTH_TOKEN}
35+
always-auth=true
36+
EOF
37+
env:
38+
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_PACKAGES_TOKEN }}
39+
3040
- name: Install dependencies
3141
run: yarn install --frozen-lockfile
3242

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ yarn add react-native-contacts-last-updated
99

1010
# iOS
1111
cd ios && pod install
12+
# If your project relies on Bundler, run `bundle install` first.
1213
```
1314

1415
Rebuild your app after installing. The module automatically uses the TurboModule bridge when it is available, and falls back to the classic `NativeModules` bridge otherwise.

__tests__/config.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ import path from "path";
44
describe("react-native config", () => {
55
it("exposes podspec path and android package", () => {
66
const config = require("../react-native.config.js");
7-
expect(config).toHaveProperty("dependency.platforms.ios.podspecPath");
7+
expect(config).toHaveProperty("dependency.platforms.ios.podspec");
88
expect(config).toHaveProperty("dependency.platforms.android.packageImportPath", "com.contactsupdated.ContactsLastUpdatedPackage");
99
expect(config).toHaveProperty("dependency.platforms.android.packageInstance", "new ContactsLastUpdatedPackage()");
1010

11-
const podspecPath = config.dependency.platforms.ios.podspecPath as string;
11+
const podspecPath = config.dependency.platforms.ios.podspec as string;
1212
const resolved = path.resolve(__dirname, "..", podspecPath);
1313
expect(fs.existsSync(resolved)).toBe(true);
1414
});

react-native.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ module.exports = {
22
dependency: {
33
platforms: {
44
ios: {
5-
podspecPath: './react-native-contacts-last-updated.podspec',
5+
podspec: './react-native-contacts-last-updated.podspec',
66
},
77
android: {
88
sourceDir: './android',

0 commit comments

Comments
 (0)