Commit 3579c0b
committed
Address code review: drop Sidekiq example, small polish
Review findings audited:
1. **Sidekiq example dropped.** `Sidekiq.default_worker_options` is
a deprecated alias on Sidekiq 6.5+ and only removed outright in
7.0, so the "6.x → 7.x" framing was ambiguous — teaches a
genuine two-sided case only for ≤ 6.4 → 7.0; on 6.5 → 7.0 it's
deprecation-only, the exact anti-pattern invariant #7 excludes.
Same reasoning that dropped the `session_store` example earlier
in this PR. Removed rather than tightened because the boundary
caveat would lengthen the skill for a gem-specific illustration.
2. **`update_attributes` version — verified correct, no change.**
Rails 6.1 `activerecord/CHANGELOG.md` reads "Remove deprecated
`ActiveRecord::Base#update_attributes` and `#update_attributes!`"
(verified via `gh api ...?ref=v6.1.0`). The PR's "prior to the
6.1 removal" phrasing is accurate; no fix needed.
3. **Gem-placement nudge in basic-setup.md Step 3.** Added one
line noting that if the 4.2 app already has `gem 'ignorable'`
at Gemfile root, it should move into the `else` branch so it's
installed only for Rails 4.2.
4. **CHANGELOG v1.1 entry bulletized.** The five distinct changes
(example swap, new "When NOT to Branch" section, broadened
feature-detection rule, polarity standardization, invariant #7,
session_store + Sidekiq removals) now read as separate bullets
instead of one run-on paragraph.
5. **code-patterns.md intro nudge.** Added one sentence noting the
`ignored_columns` example's pattern ("gem-provided API replaced
by a native Rails API with different syntax") applies to any
adjacent-version boundary, not just 4.2 → 5.0 — keeps the older
version numbers from dating the teaching.1 parent 3ed8972 commit 3579c0b
3 files changed
Lines changed: 10 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
5 | 10 | | |
6 | 11 | | |
7 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
29 | 31 | | |
30 | 32 | | |
31 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
9 | 11 | | |
10 | 12 | | |
11 | 13 | | |
| |||
76 | 78 | | |
77 | 79 | | |
78 | 80 | | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | 81 | | |
95 | 82 | | |
96 | 83 | | |
| |||
0 commit comments