Sweep .rspec for deprecation behavior in Step 0#20
Open
JuanVqz wants to merge 1 commit into
Open
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to ombulabs/claude-code_rails-upgrade-skill#100 (same gap, different repo).
Summary
Verify Deprecation Warnings Are Not Silenced) indual-boot/workflows/setup-workflow.mdto sweep.rspec,spec/.rspec,spec/spec_helper.rb,spec/rails_helper.rb,spec/support/,Rakefile, andlib/tasks/. The current grep targetsconfig/only, which misses RSpec autoloads and helper hooks.dual-boot/references/deprecation-tracking.mdunder "Detect If Deprecations Are Silenced", with a.rspecautoload example and the block-form silencing pattern (Deprecation.silence do ... end).ActiveSupport::Deprecation\.silence\bfor block-form silencing. The\bword boundary keeps it from matchingsilenced(already covered by the assignment branch).raise_errors_for_deprecationsautoloads when found.Why this matters
The silence check is meant to answer "what is the project's deprecation behavior right now?" before starting an upgrade. RSpec autoloads
-r raise_errors_for_deprecationsfrom.rspec, and helper hooks likeRSpec.configure { |c| c.raise_errors_for_deprecations! }install raise behavior. A single line in.rspeccan change how every test failure is interpreted — and nothing about it lives underconfig/. Without these locations in the sweep, "no deprecation warnings in the log" can mean "they are being silenced", and "every test fails after the upgrade" can mean "they have been raising for a long time, unrelated to the upgrade".Test plan
.rspecautoloadedraise_errors_for_deprecationsand the original Step 0 grep would have missed it..rspecautoloads, theraise_errors_for_deprecations!helper hook, and anyDeprecation.silence doblocks alongside the existing assignment-form patterns.Note
The original gap was reported against
OmbuLabs/claude-code_rails-upgrade-skill(issue #100, PR #101). This PR carries the same fix into the dual-boot skill where the parallel guidance lives. Linking instead of opening a duplicate issue.