[Bugfix] fix spec/label/annotation changes can't trigger redownload

Author: pallasathena92

pkg/modelagent/scout.go

@@ -362,7 +362,7 @@ func (w *Scout) updateBaseModel(old, new interface{}) {
 		hasChanges = hasChanges || (result != "")
 	}
 
-	if hasChanges && w.shouldDownloadModelInUpdateEvent(newBaseModel.Spec.Storage) {
+	if hasChanges && w.shouldDownloadModel(newBaseModel.Spec.Storage) {
 		w.logger.Infof("BaseModel %s needs refresh in namespace %s", newBaseModel.GetName(), newBaseModel.GetNamespace())
 		w.generateDownloadOverrideTaskBasedOnBaseModel(newBaseModel)
 	}
@@ -417,7 +417,7 @@ func (w *Scout) updateClusterBaseModel(old, new interface{}) {
 		hasChanges = hasChanges || (result != "")
 	}
 
-	if hasChanges && w.shouldDownloadModelInUpdateEvent(newClusterBaseModel.Spec.Storage) {
+	if hasChanges && w.shouldDownloadModel(newClusterBaseModel.Spec.Storage) {
 		w.logger.Infof("ClusterBaseModel %s need refresh", newClusterBaseModel.GetName())
 		w.generateDownloadOverrideTaskBasedOnClusterBaseModel(newClusterBaseModel)
 	}
@@ -547,12 +547,6 @@ func (w *Scout) shouldDownloadModel(storageSpec *v1beta1.StorageSpec) bool {
 	return w.shouldDownloadModelCommon(storageSpec, true)
 }
 
-// shouldDownloadModelInUpdateEvent mirrors shouldDownloadModel logic but uses a default false decision,
-// allowing callers to opt-in specific cases for updates if needed.
-func (w *Scout) shouldDownloadModelInUpdateEvent(storageSpec *v1beta1.StorageSpec) bool {
-	return w.shouldDownloadModelCommon(storageSpec, false)
-}
-
 func (w *Scout) nodeMatchesSelectorTerm(term v1.NodeSelectorTerm) bool {
 	// Check match expressions
 	for _, expr := range term.MatchExpressions {