Remove unnecessary dead store to local variable#4430
Open
melissalinkert wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4235.
I am pretty sure this is not breaking, but we'll want to keep an eye out for test failures in tonight's build. It's probably also worth double-checking that converting one or two datasets to DICOM works as before; I tried
bfconvert -noflat CMU-1.svs CMU-1.dcm -compression JPEGwithout issue, but an extra check can't hurt.A more-breaking change would be to deprecate/remove the
locationvariable from the constructors, but I'm not 100% certain that's what we want. Leaving the possibility of usinglocationat a later date may still be useful.