Skip to content

Commit 698dd47

Browse files
authored
Merge pull request #114 from melissalinkert/java-version
Require Java 11 at runtime, build on Java 21/25
2 parents 70a35d7 + c723c43 commit 698dd47

4 files changed

Lines changed: 14 additions & 32 deletions

File tree

.github/workflows/codeql.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,15 @@ jobs:
3434

3535
steps:
3636
- name: Checkout repository
37-
uses: actions/checkout@v4
37+
uses: actions/checkout@v6
3838

3939
- name: Initialize CodeQL
40-
uses: github/codeql-action/init@v3
40+
uses: github/codeql-action/init@v4
4141
with:
4242
languages: ${{ matrix.language }}
4343
build-mode: ${{ matrix.build-mode }}
4444

4545
- name: Perform CodeQL Analysis
46-
uses: github/codeql-action/analyze@v3
46+
uses: github/codeql-action/analyze@v4
4747
with:
4848
category: "/language:${{matrix.language}}"

.github/workflows/maven.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@ jobs:
1515
contents: read
1616
strategy:
1717
matrix:
18-
java: [8, 11, 17, 21]
18+
java: [11, 17, 21, 25]
1919
os: [ubuntu-latest, windows-latest, macos-latest]
2020
runs-on: ${{ matrix.os }}
2121
env:
2222
maven_commands: test javadoc:javadoc # default is install
2323
steps:
24-
- uses: actions/checkout@v4
24+
- uses: actions/checkout@v6
2525
- name: Set up JDK ${{ matrix.java }}
26-
uses: actions/setup-java@v4
26+
uses: actions/setup-java@v5
2727
with:
2828
java-version: ${{ matrix.java }}
2929
distribution: 'zulu'
@@ -37,7 +37,7 @@ jobs:
3737
if: startsWith(github.ref, 'refs/tags')
3838
runs-on: ubuntu-latest
3939
steps:
40-
- uses: actions/checkout@v4
40+
- uses: actions/checkout@v6
4141
- name: Create a GitHub release
4242
run: gh release create --generate-notes "${GITHUB_REF#refs/tags/}"
4343
env:

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ following before submitting a pull request:
2222

2323
* verify that the branch merges cleanly into ```master```
2424
* verify that the branch builds using Maven
25-
* verify that the branch does not use syntax or API specific to Java 1.9+
25+
* verify that the branch does not use syntax or API specific to Java > 11
2626
* run the unit tests (```mvn test```) and correct any failures
2727
* make sure that your commits contain the correct authorship information
2828
* make sure that the commit messages or pull request comment contains

pom.xml

Lines changed: 6 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,8 @@
185185
</dependencies>
186186

187187
<properties>
188+
<testng.version>7.9.0</testng.version>
189+
188190
<!-- NB: Avoid platform encoding warning when copying resources. -->
189191
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
190192
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
@@ -214,11 +216,9 @@
214216
<groupId>org.apache.maven.plugins</groupId>
215217
<artifactId>maven-compiler-plugin</artifactId>
216218
<version>3.14.0</version>
217-
<!-- Require the Java 8 platform. -->
219+
<!-- Require the Java 11 platform. -->
218220
<configuration>
219-
<release>8</release>
220-
<source>8</source>
221-
<target>8</target>
221+
<release>11</release>
222222
</configuration>
223223
</plugin>
224224

@@ -325,11 +325,11 @@
325325
<artifactId>maven-javadoc-plugin</artifactId>
326326
<!-- NB: The same version declaration and configuration block also
327327
appears in the <reporting> section, and must be kept in sync. -->
328-
<version>3.10.0</version>
328+
<version>3.12.0</version>
329329
<configuration>
330330
<failOnError>true</failOnError>
331331
<links>
332-
<link>http://docs.oracle.com/javase/8/docs/api/</link>
332+
<link>https://docs.oracle.com/en/java/javase/11/docs/api/</link>
333333
</links>
334334
</configuration>
335335
<executions>
@@ -455,23 +455,5 @@
455455
</plugins>
456456
</build>
457457
</profile>
458-
<profile>
459-
<id>jdk8-only</id>
460-
<activation>
461-
<jdk>(,11)</jdk>
462-
</activation>
463-
<properties>
464-
<testng.version>7.5</testng.version>
465-
</properties>
466-
</profile>
467-
<profile>
468-
<id>jdk11+</id>
469-
<activation>
470-
<jdk>[11,)</jdk>
471-
</activation>
472-
<properties>
473-
<testng.version>7.9.0</testng.version>
474-
</properties>
475-
</profile>
476458
</profiles>
477459
</project>

0 commit comments

Comments
 (0)