fix: type error for non-string path params

Author: omermecitoglu

src/core/definer.ts

@@ -1,6 +1,7 @@
 import { customErrorTypes } from "~/types/error";
 import type { HttpMethod } from "~/types/http";
 import type { RouteHandler, RouteMethodHandler } from "~/types/next";
+import type { FixPathParams } from "~/types/path-params";
 import type { ResponseCollection } from "~/types/response";
 import { parseRequestBody, resolveRequestBody } from "./body";
 import { resolveParams } from "./params";
@@ -62,8 +63,8 @@ type RouteOptions<
     issues?: ZodIssue[],
   ) => Res,
   middleware?: (
-    hander: RouteMethodHandler<PathParamsInput, Req, Res>,
-  ) => RouteMethodHandler<PathParamsInput, Req, Res>,
+    hander: RouteMethodHandler<FixPathParams<PathParamsInput>, Req, Res>,
+  ) => RouteMethodHandler<FixPathParams<PathParamsInput>, Req, Res>,
   security?: OperationObject["security"],
 } & (RouteWithBody<RequestBodyInput, RequestBodyOutput> | RouteWithoutBody);
 
@@ -80,12 +81,12 @@ function defineRoute<
   ResDef extends Record<string, unknown>,
 >(input: RouteOptions<
   M, PPI, PPO, QPI, QPO, RBI, RBO, MwReq, MwRes, ResDef
->) {
-  const handler: RouteMethodHandler<PPI, MwReq, MwRes> = async (request, context) => {
+>): RouteHandler<M, FixPathParams<PPI>, MwReq, MwRes> {
+  const handler: RouteMethodHandler<FixPathParams<PPI>, MwReq, MwRes> = async (request, context) => {
     try {
       const { searchParams } = new URL(request.url);
       // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-      const nextSegmentParams = context ? (await context.params) : undefined;
+      const nextSegmentParams = context ? (await context.params) as PPI : undefined;
       const pathParams = parsePathParams(nextSegmentParams, input.pathParams) as PPO;
       const queryParams = parseSearchParams(searchParams, input.queryParams) as QPO;
       const body = await parseRequestBody(request, input.method, input.requestBody, input.hasFormData) as RBO;
@@ -154,10 +155,10 @@ function defineRoute<
   if (input.middleware) {
     const alteredHandler = input.middleware(handler);
     alteredHandler.apiData = handler.apiData;
-    return { [input.method]: alteredHandler } as RouteHandler<M, PPI, MwReq, MwRes>;
+    return { [input.method]: alteredHandler } as RouteHandler<M, FixPathParams<PPI>, MwReq, MwRes>;
   }
 
-  return { [input.method]: handler } as RouteHandler<M, PPI, MwReq, MwRes>;
+  return { [input.method]: handler } as RouteHandler<M, FixPathParams<PPI>, MwReq, MwRes>;
 }
 
 export default defineRoute;

src/core/path-params.ts

@@ -1,7 +1,7 @@
 import { safeParse } from "./zod-error-handler";
 import type { ZodError, ZodType } from "zod";
 
-export default function parsePathParams<I, O>(source?: I, schema?: ZodType<O, I>) {
+export default function parsePathParams<I, O>(source?: NoInfer<I>, schema?: ZodType<O, I>) {
   if (!schema) return null;
   if (!source) throw new Error("UNNECESSARY_PATH_PARAMS");
   try {

src/types/next.ts

@@ -1,11 +1,11 @@
 import type { HttpMethod } from "./http";
 import type { OperationObject } from "@omer-x/openapi-types/operation";
 
-type RouteHandlerContext<PathParams> = {
+type RouteHandlerContext<PathParams extends Record<string, string>> = {
   params: Promise<PathParams>,
 };
 
-export type RouteMethodHandler<PathParamsInput, Req, Res> = ((
+export type RouteMethodHandler<PathParamsInput extends Record<string, string>, Req, Res> = ((
   request: Req,
   context: RouteHandlerContext<PathParamsInput>,
 ) => Promise<Res>) & {
@@ -14,7 +14,7 @@ export type RouteMethodHandler<PathParamsInput, Req, Res> = ((
 
 export type RouteHandler<
   HM extends HttpMethod,
-  PathParamsInput,
+  PathParamsInput extends Record<string, string>,
   Req,
   Res,
 > = Record<

src/types/path-params.ts

@@ -0,0 +1,3 @@
+export type FixPathParams<T> = {
+  [K in keyof T]: string;
+};