Fix PHP 8.5 incompatibility

curry684 · curry684 · commit b766d5a691ac · 2025-11-21T12:51:17.000+01:00
diff --git a/src/Adapter/Doctrine/ORMAdapter.php b/src/Adapter/Doctrine/ORMAdapter.php
@@ -143,8 +143,9 @@ protected function getAliases(AdapterQuery $query): array
 
                 list($origin, $target) = explode('.', $join->getJoin());
 
+                assert(is_string($alias = $join->getAlias()));
                 $mapping = $aliases[$origin][1]->getAssociationMapping($target);
-                $aliases[$join->getAlias()] = [$join->getJoin(), $this->manager->getMetadataFactory()->getMetadataFor($mapping['targetEntity'])];
+                $aliases[$alias] = [$join->getJoin(), $this->manager->getMetadataFactory()->getMetadataFor($mapping['targetEntity'])];
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -143,8 +143,9 @@ protected function getAliases(AdapterQuery $query): array`
`143`	`143`
`144`	`144`	`list($origin, $target) = explode('.', $join->getJoin());`
`145`	`145`
	`146`	`+ assert(is_string($alias = $join->getAlias()));`
`146`	`147`	`$mapping = $aliases[$origin][1]->getAssociationMapping($target);`
`147`		`- $aliases[$join->getAlias()] = [$join->getJoin(), $this->manager->getMetadataFactory()->getMetadataFor($mapping['targetEntity'])];`
	`148`	`+ $aliases[$alias] = [$join->getJoin(), $this->manager->getMetadataFactory()->getMetadataFor($mapping['targetEntity'])];`
`148`	`149`	`}`
`149`	`150`	`}`
`150`	`151`