Option to add row count lazily#410
Open
MieskeB wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #410 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 40 40
Lines 1087 1087
=======================================
Hits 1035 1035
Misses 52 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone! For our project, we have a huge table displayed using datatables-bundle. Because of the forced 'count' queries, the request becomes extremely slow. Therefore, I have implemented the option to lazily count the amount of rows displayed.
Current flow in
ORMAdapter.php:Mostly step 2, but also step 4 make the request much longer when big tables are being used. Therefore, I added an option to use the following flow (default remains the top flow).
To the ORMAdapter, the following properties can be added:
lazy_total_countfalselazy_filtered_countfalseThis is controller code is used in my test project:
Tests and documentation have also been included