👷 Lock/Unlock Deps Pattern#157
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 16581131935Details
💛 - Coveralls |
pboling
changed the title
Two often conflicting goals resolved - deps_unlocked.yml - All runtime & dev dependencies, but does not have a `gemfiles/*.gemfile.lock` committed - Uses an Appraisal2 "deps_unlocked" gemfile, and the current MRI Ruby release - Know when new dependency releases will break local dev with unlocked dependencies - Broken workflow indicates that new releases of dependencies may not work - deps_locked.yml - All runtime & dev dependencies, and has a `Gemfile.lock` committed - Uses the project's main Gemfile, and the current MRI Ruby release - Matches what contributors and maintainers use locally for development - Broken workflow indicates that a new contributor will have a bad time
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two often conflicting goals resolved
deps_unlocked.yml
gemfiles/*.gemfile.lockcommitteddeps_locked.yml
Gemfile.lockcommitted@kou - FYI, This is the pattern I would have used in ruby/rexml#279, had I completed it.