Ui-tabulator does not support Node-RED timestamp

[teluse7]

Node-RED timestamp is a number of milliseconds from 1970.
I corrected the file ui-tabulator.umd.js and now this timestamp work natively. I added the "x" type.
Please, replace this file and build a new version.

ui-tabulator.umd.js

[colinl]

I don't understand exactly what support you have added to the node. Do you mean that you have added support for javascript Date format or for timestamps in ticks? Please explain exactly what you are proposing with an example of how it would be used.

To suggest changes to a node you should fork the github repository into your own github account, make the changes required on a branch there and submit a pull request here.

The file ui-tabulator.umd.js is an auto generated file created when the node is built. The file you need to edit may be ui/components/UITabulator.vue.

See here for how to build the node once you have edited the files. In particular, the section Developing Locally explains how to do it using the example node.

[omrid01]

Can you please explain what you are asking for, and the actual use-case.
Colin is correct: the .umd.js file is the compiled output of the .vue file, which is the actual JS code of the client-side widget, hence any change should come there.
Tabulator embeds the luxon package for date & time management, which has an extremely rich variety of date/time formats, for both display & edit. If you need anything special, you can easily set your own custom date/time formatter, and I'll be happy to show you how.

[teluse7]

Can you please explain what you are asking for, and the actual use-case. Colin is correct: the .umd.js file is the compiled output of the .vue file, which is the actual JS code of the client-side widget, hence any change should come there. Tabulator embeds the luxon package for date & time management, which has an extremely rich variety of date/time formats, for both display & edit. If you need anything special, you can easily set your own custom date/time formatter, and I'll be happy to show you how.

In ui-tabulator, if you specify the keyword "iso" instead of the format in the inputformat parameter for datetime, the ui-tabulator.umd.js file specifies that the fromISO function will be executed. I've implemented this analogy: if you specify the keyword "x," the fromMillis function will be executed. This worked in older versions of ui-tabulator before the transition from moment.js to luxon.js. This tick timestamp type is the primary type for Node-RED and is used in all core nodes, such as Inject, Change, Trigger, Join, etc. It's precisely this type that's been unsupported in newer versions of ui-tabulator. I actually proposed implementing built-in native support for the core Node-RED type.
After reviewing the entire project, I found the words "iso" and fromISO only in one file, resources/ui-tabulator.umd.js, which doesn't and can't be built from the only one Vue file in the project, ui/components/UITabulator.vue.
I made the changes there, and everything worked perfectly out of the box.
Below are screenshots of the changes, how to use them in ui-tabulator itself, and what the main timestamp looks like in Node-RED.

[omrid01]

Hi, thanks for the analysis.
As of Tabulator version 5.0, it stopped using moment.js and moved to luxon, which has some advantages. A few things were not fully backwards compatible, but the move was mostly seamless.

The ui-tabulator node is a wrapper around the Tabulator package. The node adds a lot of new functionality, but it's all on top of Tabulator, i.e. never changes anything inside Tabulator (or its dependencies).

So bottom line, it is what it is, I cannot change or branch the imported external packages (Tabulator & luxon). The code you pointed out from the compiled output (umd.js) from these packages. I searched my own code (node_modules\@omrid01\node-red-dashboard-2-table-tabulator\ui\components.vue) - It doesn't include the code (fromISO etc.) you highlighted in the umd.js.

If you specifically want to have a date field based on unix epoch msecs, you can use a numeric field and define a custom formatter with a few simple JS lines of code to format/display it any way you wish.

[teluse7]

Hi, thanks for the analysis. As of Tabulator version 5.0, it stopped using moment.js and moved to luxon, which has some advantages. A few things were not fully backwards compatible, but the move was mostly seamless.

The ui-tabulator node is a wrapper around the Tabulator package. The node adds a lot of new functionality, but it's all on top of Tabulator, i.e. never changes anything inside Tabulator (or its dependencies).

So bottom line, it is what it is, I cannot change or branch the imported external packages (Tabulator & luxon). The code you pointed out from the compiled output (umd.js) from these packages. I searched my own code (node_modules\@omrid01\node-red-dashboard-2-table-tabulator\ui\components.vue) - It doesn't include the code (fromISO etc.) you highlighted in the umd.js.

If you specifically want to have a date field based on unix epoch msecs, you can use a numeric field and define a custom formatter with a few simple JS lines of code to format/display it any way you wish.

I checked the ui-tabulator dependencies and found that the type inconsistency I detected was contained in the table-tabulator package. I've fixed six files in this package, which I've attached below. I've also created an issue for the table-tabulator package to include them.
tabulator-tables/tabulator#4864
However, as far as I understand, you're not using this package directly, but rather a compiled version of some earlier version. It's located in your resources. Accordingly, I've fixed this file (ui-tabulator.umd.js). You can use the new version to rebuild the ui-tabulator package. And when you need to commit the table-tabulator version again and review this file, my changes will already be included there (in the table-tabulator project itself). These processes can also occur in parallel.
Therefore, I ask you to rebuild ui-tabulator with this new version of this file.

ui-tabulator.umd.js

From table-tabulator
src/js/modules/Sort/defaults/sorters

datetime.js

src/js/modules/Format/defaults/formatters

datetime.js
datetimediff.js

src/js/modules/Edit/defaults/editors

date.js
datetime.js
time.js

[omrid01]

Hi, thank you.
I am about to release a new version of the node, with some fixes. I will bump Tabulator to latest version (6.4), let's see if it solves the type inconsistencies you detected.

[teluse7]

Hi, thank you. I am about to release a new version of the node, with some fixes. I will bump Tabulator to latest version (6.4), let's see if it solves the type inconsistencies you detected.

Hello
No, that won't solve it, since I only proposed the changes to table-tabulator yesterday, and they haven't implemented them yet.
I can fix your new ui-tabulator.umd.js file until they've made them. It's not difficult and won't cause any problems.
Just let me know when you build the new ui-tabulator.umd.js, and I'll make a version with the changes.
And I'm sure we'll gradually implement them into table-tabulator itself. I've fixed the files, but someone needs to include the fixes.

[teluse7]

Hi, thank you. I am about to release a new version of the node, with some fixes. I will bump Tabulator to latest version (6.4), let's see if it solves the type inconsistencies you detected.

Нi, my changes to the table-tabulator project were merged today, and it looks like they'll now be included in version 4.6.1. If you can wait and get 4.6.1 instead of 4.6, that would be great!
tabulator-tables/tabulator#4864

[omrid01]

Sure. My new release is not urgent. I'll wait for you to notify me that your tabulator fix has been merged & released, and then update my node.