Merge branch 'dev/interProcCom' into 'master'

Author: florinc

InterProcessCommunication/TradingApp/Modules/Quotations/Quotation.Services/QuotationService.cs

@@ -6,20 +6,20 @@
 namespace Quotations.Services
 {
     [Service(typeof(IQuotationService))]
-    class QuotationService : IQuotationService
+    internal class QuotationService : IQuotationService
     {
-        private readonly Quotation[] array = 
-            {
-                new Quotation {AskPrice = 10.50m, BidPrice = 10.55m, SecurityCode = "ING.S.NYSE"},
-                new Quotation {AskPrice = 12.50m, BidPrice = 12.55m, SecurityCode = "ING.B.NYSE"},
-                new Quotation {AskPrice = 10.70m, BidPrice = 10.75m, SecurityCode = "AAPL.B.NASDAQ"},
-                new Quotation {AskPrice = 11.50m, BidPrice = 11.55m, SecurityCode = "AAPL.S.NASDAQ"},
-                new Quotation {AskPrice = 16.50m, BidPrice = 16.55m, SecurityCode = "MSFT.B.NASDAQ"},
-                new Quotation {AskPrice = 17.50m, BidPrice = 17.55m, SecurityCode = "ING.B.AEX"},
-                new Quotation {AskPrice = 10.51m, BidPrice = 10.59m, SecurityCode = "ING.S.AEX"},
-            };
-        
-        public Quotation[] GetQuotations(string exchange, string instrument, DateTime @from, DateTime to)
+        private readonly Quotation[] array =
+        {
+            new Quotation {AskPrice = 10.50m, BidPrice = 10.55m, SecurityCode = "ING.S.NYSE"},
+            new Quotation {AskPrice = 12.50m, BidPrice = 12.55m, SecurityCode = "ING.B.NYSE"},
+            new Quotation {AskPrice = 10.70m, BidPrice = 10.75m, SecurityCode = "AAPL.B.NASDAQ"},
+            new Quotation {AskPrice = 11.50m, BidPrice = 11.55m, SecurityCode = "AAPL.S.NASDAQ"},
+            new Quotation {AskPrice = 16.50m, BidPrice = 16.55m, SecurityCode = "MSFT.B.NASDAQ"},
+            new Quotation {AskPrice = 17.50m, BidPrice = 17.55m, SecurityCode = "ING.B.AEX"},
+            new Quotation {AskPrice = 10.51m, BidPrice = 10.59m, SecurityCode = "ING.S.AEX"}
+        };
+
+        public Quotation[] GetQuotations(string exchange, string instrument, DateTime from, DateTime to)
         {
             var result = array.Where(q => q.SecurityCode.Contains(exchange));
 

InterProcessCommunication/TradingApp/Modules/Sales/Sales.Services/OrdersService.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Linq;
 using System.Threading.Tasks;
 using Contracts.Quotations.Services;
 using Contracts.Sales.Services;
@@ -9,25 +8,23 @@
 namespace Sales.Services
 {
     [Service(typeof(IOrdersService))]
-    class OrderingService : IOrdersService
+    public class OrderingService : IOrdersService
     {
         private readonly IQuotationService quotationService;
-        private readonly IRepository repository;
 
-        public OrderingService(IQuotationService quotationService, IRepository repository)
+        private readonly List<LimitOrder> limitOrders = new List<LimitOrder>();
+
+        public OrderingService(IQuotationService quotationService)
         {
             this.quotationService = quotationService;
-            this.repository = repository;
         }
 
         public void PlaceSellLimitOrder(string securityCode, decimal sellingPrice, DateTime validUntil)
         {
-            List<LimitOrder> limitOrders = new List<LimitOrder>();
             var todayQuotations = quotationService.GetQuotations(securityCode, DateTime.Today.AddDays(-1), DateTime.Today);
             foreach (var quotation in todayQuotations)
             {
                 if (quotation.AskPrice >= sellingPrice)
-                {
                     limitOrders.Add(new LimitOrder
                     {
                         SecurityCode = securityCode,
@@ -36,21 +33,15 @@ public void PlaceSellLimitOrder(string securityCode, decimal sellingPrice, DateT
                         Price = sellingPrice,
                         ValidUntil = validUntil
                     });
-                }
             }
-
-            repository.SaveAll(limitOrders);
         }
 
         public void PlaceBuyLimitOrder(string securityCode, decimal buyingPrice, DateTime validUntil)
         {
-            List<LimitOrder> limitOrders= new List<LimitOrder>();
             var todayQuotations = quotationService.GetQuotations(securityCode, DateTime.Today.AddDays(-1), DateTime.Today);
             foreach (var quotation in todayQuotations)
             {
                 if (quotation.BidPrice <= buyingPrice)
-                {
-
                     limitOrders.Add(new LimitOrder
                     {
                         SecurityCode = securityCode,
@@ -59,15 +50,12 @@ public void PlaceBuyLimitOrder(string securityCode, decimal buyingPrice, DateTim
                         Price = buyingPrice,
                         ValidUntil = validUntil
                     });
-                }
             }
-
-            repository.SaveAll(limitOrders);
         }
 
         public LimitOrder[] GetLimitOrders()
         {
-            return repository.GetEntities<LimitOrder>().ToArray();
+            return limitOrders.ToArray();
         }
     }
-}
+}