ExprCacheHelper: Reduce PHPParser instantiation#41
Closed
staabm wants to merge 1 commit into
Closed
Conversation
staabm
force-pushed
the
faster
branch
4 times, most recently
from
ff84324 to
9055b0e
Compare
staabm
commented
Feb 22, 2026
|
|
||
| /** | ||
| * @return array<string, mixed | ||
| * @return array<string, mixed> |
Author
There was a problem hiding this comment.
this makes me feel this repo is missing a phpstan job
Owner
There was a problem hiding this comment.
It has all the CI checks but it's a failing mess. Because it's tricky to support all of the PHP versions at the same time, so for a long time I was fine by checking manually PHPUnit and knew what tests were failing before.
Owner
|
Merged, released as 6.65.0.10. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReflectionConstant/ReflectionParameter->importFromCache() is expensive.
it is dominated by PHPParser overhead
looks like the parser instantiation happens multiple times
before/after PR when running PHPStan on a single file change
covered by test in phpstan/phpstan-src#5023