Skip to content

Commit 66953dc

Browse files
committed
address review comment
Signed-off-by: chenwei.sun <chenwei.sun@intel.com>
1 parent f257a9a commit 66953dc

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

clang/lib/DPCT/MigrateScript/MigrateCmakeScript.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -575,15 +575,15 @@ applyCmakeMigrationRules(const clang::tooling::UnifiedPath InRoot,
575575

576576
// cmake systaxes need to be processed by implicit migration rules, as they are
577577
// difficult to be described with yaml based rule syntax.
578-
static const std::vector<std::string> ImplicitMigrationRules = {
578+
static const std::vector<std::string> BuiltinMigrationRules = {
579579
"cmake_minimum_required", "execute_process", "cuda_compile",
580580
"cuda_compile_fatbin"};
581581

582-
static void reserveImplicitMigrationRules() {
583-
for (const auto &Rule : ImplicitMigrationRules) {
582+
static void reserveBuiltinMigrationRules() {
583+
for (const auto &Rule : BuiltinMigrationRules) {
584584
MetaRuleObject::PatternRewriter PrePR;
585585
PrePR.BuildScriptSyntax = Rule;
586-
PrePR.RuleId = "implicit_rule_" + Rule;
586+
PrePR.RuleId = "builtin_rule_" + Rule;
587587

588588
auto Iter = CmakeBuildInRules.find(PrePR.BuildScriptSyntax);
589589
if (Iter != CmakeBuildInRules.end()) {
@@ -607,7 +607,7 @@ void doCmakeScriptMigration(const clang::tooling::UnifiedPath &InRoot,
607607
loadBufferFromFile(InRoot, OutRoot, CmakeScriptFileBufferMap);
608608
unifyInputFileFormat(CmakeScriptFileBufferMap, ScriptFileCRLFMap);
609609
convertAllCmakeCommandsToLowerCase();
610-
reserveImplicitMigrationRules();
610+
reserveBuiltinMigrationRules();
611611
doCmakeScriptAnalysis();
612612
applyCmakeMigrationRules(InRoot, OutRoot);
613613
storeBufferToFile(CmakeScriptFileBufferMap, ScriptFileCRLFMap);
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
// CHECK: Warning: Only CMake scripts will be migrated as no --migrate-build-script option is provided.
22
// CHECK: dpct exited with code: 4 (Migration of build script(s) completed.)
3-
// CHECK: [Warning]: Two migration rules (Rule:implicit_rule_execute_process, Rule:rule_execute_process) are duplicated, the migration rule (Rule:implicit_rule_execute_process) is ignored.
3+
// CHECK: [Warning]: Two migration rules (Rule:builtin_rule_execute_process, Rule:rule_execute_process) are duplicated, the migration rule (Rule:builtin_rule_execute_process) is ignored.
44
// CHECK: Processing: {{(.+)}}input.cmake

0 commit comments

Comments
 (0)