Skip to content

Commit 8cd2f16

Browse files
Changed init_attr migration logic
1 parent 56113ab commit 8cd2f16

2 files changed

Lines changed: 17 additions & 12 deletions

File tree

clang/lib/DPCT/RulesSHMEM/APINamesNvshmem.inc

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -203,13 +203,18 @@
203203
FEATURE_REQUEST_FACTORY(HelperFeatureEnum::device_ext,
204204
CALL_FACTORY_ENTRY("nvshmem_init", CALL("ishmem_init")))
205205

206-
HEADER_INSERT_FACTORY(HeaderType::HT_DPCT_SHMEM_Utils,
207-
FEATURE_REQUEST_FACTORY(
208-
HelperFeatureEnum::device_ext,
209-
CALL_FACTORY_ENTRY("nvshmemx_init_attr",
210-
CALL(MapNames::getDpctNamespace() +
211-
"shmem::init_attr",
212-
ARG(0), ARG(1)))))
206+
HEADER_INSERT_FACTORY(
207+
HeaderType::HT_DPCT_SHMEM_Utils,
208+
FEATURE_REQUEST_FACTORY(
209+
HelperFeatureEnum::device_ext,
210+
CALL_FACTORY_ENTRY(
211+
"nvshmemx_init_attr",
212+
CALL(MapNames::getDpctNamespace() + "shmem::init_attr",
213+
makeCombinedArg(
214+
makeCombinedArg(
215+
ARG("static_cast<ishmemx_runtime_type_t>("), ARG(0)),
216+
ARG(")")),
217+
ARG(1)))))
213218

214219
FEATURE_REQUEST_FACTORY(HelperFeatureEnum::device_ext,
215220
CALL_FACTORY_ENTRY("nvshmem_my_pe",

clang/test/dpct/nvshmem/library_setup_exit_query.cu

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,21 +60,21 @@ int main() {
6060
attr.args = args;
6161
#endif // NO_BUILD_TEST
6262

63-
// CHECK: dpct::shmem::init_attr(ISHMEMX_RUNTIME_MPI, &attr);
64-
// CHECK-NEXT: dpct::shmem::init_attr(ISHMEMX_RUNTIME_OPENSHMEM, &attr);
65-
// CHECK-NEXT: dpct::shmem::init_attr(ISHMEMX_RUNTIME_MPI | ISHMEMX_RUNTIME_OPENSHMEM, &attr);
63+
// CHECK: dpct::shmem::init_attr(static_cast<ishmemx_runtime_type_t>(ISHMEMX_RUNTIME_MPI), &attr);
64+
// CHECK-NEXT: dpct::shmem::init_attr(static_cast<ishmemx_runtime_type_t>(ISHMEMX_RUNTIME_OPENSHMEM), &attr);
65+
// CHECK-NEXT: dpct::shmem::init_attr(static_cast<ishmemx_runtime_type_t>(ISHMEMX_RUNTIME_MPI | ISHMEMX_RUNTIME_OPENSHMEM), &attr);
6666
nvshmemx_init_attr(NVSHMEMX_INIT_WITH_MPI_COMM, &attr);
6767
nvshmemx_init_attr(NVSHMEMX_INIT_WITH_SHMEM, &attr);
6868
nvshmemx_init_attr(NVSHMEMX_INIT_WITH_MPI_COMM | NVSHMEMX_INIT_WITH_SHMEM, &attr);
6969

7070
// CHECK: unsigned int rt = ISHMEMX_RUNTIME_MPI;
7171
// CHECK-NEXT: rt = ISHMEMX_RUNTIME_OPENSHMEM;
72-
// CHECK-NEXT: dpct::shmem::init_attr(rt, &attr);
72+
// CHECK-NEXT: dpct::shmem::init_attr(static_cast<ishmemx_runtime_type_t>(rt), &attr);
7373
unsigned int rt = NVSHMEMX_INIT_WITH_MPI_COMM;
7474
rt = NVSHMEMX_INIT_WITH_SHMEM;
7575
nvshmemx_init_attr(rt, &attr);
7676

77-
// CHECK: dpct::shmem::init_attr(0, &attr);
77+
// CHECK: dpct::shmem::init_attr(static_cast<ishmemx_runtime_type_t>(0), &attr);
7878
nvshmemx_init_attr(0, &attr);
7979

8080
// CHECK: ishmem_init();

0 commit comments

Comments
 (0)