Fixed format & addressed comments

Author: TejaX-Alaghari

clang/lib/DPCT/RulesAsm/AsmMigration.cpp

@@ -1486,13 +1486,16 @@ class SYCLGen : public SYCLGenBase {
     OS() << " }";
     endstmt();
 
-    // Declare and init vectors for storing the values of A, B & C matrix elements
+    // Declare and init vectors for storing the values of A, B & C matrix
+    // elements
     std::string InMatrixName[3] = {"A", "B", "C"};
     for (unsigned InputOp = 0; InputOp < Inst->getNumInputOperands();
          InputOp++) {
       if (auto VE =
               dyn_cast<InlineAsmVectorExpr>(Inst->getInputOperand(InputOp))) {
-        OS() << "sycl::vec<" << InMatrixType[InputOp] << ", " << VE->getNumElements() << "> " << InMatrixName[InputOp] << "Matrix_ct1(";
+        OS() << "sycl::vec<" << InMatrixType[InputOp] << ", "
+             << VE->getNumElements() << "> " << InMatrixName[InputOp]
+             << "Matrix_ct1(";
         for (unsigned Inst = 0; Inst != VE->getNumElements(); ++Inst) {
           if (isa<InlineAsmDiscardExpr>(VE->getElement(Inst)))
             continue;
@@ -1516,7 +1519,8 @@ class SYCLGen : public SYCLGenBase {
 
     OS() << "DMatrix_ct1";
     for (int i = 0; i < 3; i++)
-      OS() << ", reinterpret_cast<" << InMatrixType[i] << " *>(&" << InMatrixName[i] << "Matrix_ct1)";
+      OS() << ", reinterpret_cast<" << InMatrixType[i] << " *>(&"
+           << InMatrixName[i] << "Matrix_ct1)";
     OS() << ")";
     endstmt();
     OS() << "}";

clang/lib/DPCT/RulesAsm/Parser/AsmParser.cpp

@@ -757,9 +757,9 @@ InlineAsmParser::ActOnVectorExpr(ArrayRef<InlineAsmExpr *> Vec) {
     // Vector size must be 2, 4, or 8.
     switch (Vec.size()) {
     case 1:
-    Kind = InlineAsmVectorType::v1;
-    break;
-  case 2:
+      Kind = InlineAsmVectorType::v1;
+      break;
+    case 2:
       Kind = InlineAsmVectorType::v2;
       break;
     case 4:

clang/runtime/dpct-rt/include/dpct/math.hpp

@@ -2227,23 +2227,23 @@ void ldmatrix(uintptr_t addr, T *m1, T *m2, T *m3, T *m4, bool trans = false) {
 /// \tparam [in] MulType The type used to multiply A and B matrix elements as
 /// \tparam [in] ABType The type of the input matrix (A & B) elements
 /// \tparam [in] CDType The type of the output matrix (C & D) elements
-/// \param [in] d The elements of the output D matrix to store the result to
+/// \param [out] d The elements of the output D matrix to store the result to
 /// \param [in] a The elements of the input A matrix to be multiplied with B
 /// matrix elements
 /// \param [in] b The elements of the input B matrix to be multiplied with A
 /// matrix elements
 /// \param [in] c The elements of the input C matrix to be added with the result
 /// of A * B
 template <int M, int N, int K, typename MulType, typename ABType,
-          typename CDType, typename Op = sycl::bit_and<>>
-void mma(CDType **d, ABType *a, ABType *b, CDType *c, Op op = Op{}) {
+          typename CDType>
+void mma(CDType **d, ABType *a, ABType *b, CDType *c) {
   auto sg = sycl::ext::oneapi::this_work_item::get_sub_group();
   int lane = sg.get_local_linear_id();
 
   short ROW_LOAD_OFFSET = 4 * (lane >> 2);
   short COL_LOAD_OFFSET = 8 * (lane % 4);
 
-  if (M == 16 && N == 8 && K == 16) {
+  if constexpr (M == 16 && N == 8 && K == 16) {
     if constexpr (std::is_floating_point_v<CDType>) {
       // f32.f16.f16.f32
       for (int i = 0; i < 4; i++) {