[Coverity][Graph] Address coverity issues with graphs (#18806)

- Fix copy instead of move (522061, 522073)
- Fix auto causing copy (524557)
- Fix uncaught exceptions in `graph_mem_pool` destructor (522004)

Fixes: #18510

Author: Bensuo

sycl/source/detail/graph_impl.cpp

@@ -805,7 +805,7 @@ void exec_graph_impl::findRealDeps(
 }
 
 ur_exp_command_buffer_sync_point_t
-exec_graph_impl::enqueueNodeDirect(sycl::context Ctx,
+exec_graph_impl::enqueueNodeDirect(const sycl::context &Ctx,
                                    sycl::detail::device_impl &DeviceImpl,
                                    ur_exp_command_buffer_handle_t CommandBuffer,
                                    std::shared_ptr<node_impl> Node) {

sycl/source/detail/graph_impl.hpp

@@ -1457,7 +1457,8 @@ class exec_graph_impl {
   /// @param Node The node being enqueued.
   /// @return UR sync point created for this node in the command-buffer.
   ur_exp_command_buffer_sync_point_t
-  enqueueNodeDirect(sycl::context Ctx, sycl::detail::device_impl &DeviceImpl,
+  enqueueNodeDirect(const sycl::context &Ctx,
+                    sycl::detail::device_impl &DeviceImpl,
                     ur_exp_command_buffer_handle_t CommandBuffer,
                     std::shared_ptr<node_impl> Node);
 

sycl/source/detail/graph_memory_pool.cpp

@@ -33,7 +33,7 @@ graph_mem_pool::malloc(size_t Size, usm::alloc AllocType,
   AllocInfo.Kind = AllocType;
   // Collect relevant properties from memory pool
   if (MemPool) {
-    auto PropList = MemPool->getPropList();
+    const auto &PropList = MemPool->getPropList();
     if (PropList.has_property<property::memory_pool::zero_init>()) {
       AllocInfo.ZeroInit = true;
     }

sycl/source/detail/graph_memory_pool.hpp

@@ -8,6 +8,7 @@
 
 #pragma once
 
+#include "sycl/detail/common.hpp"
 #include <detail/physical_mem_impl.hpp>                // For physical_mem_impl
 #include <sycl/context.hpp>                            // For context
 #include <sycl/device.hpp>                             // For device
@@ -51,15 +52,19 @@ class graph_mem_pool {
                  const device &Device)
       : MGraph(GraphImpl), MContext(Context), MDevice(Device) {}
   ~graph_mem_pool() {
-    for (auto &[Ptr, AllocInfo] : MAllocations) {
-      // Unmap allocations if required before physical memory is released
-      // Physical mem is released when MPhysicalMem is cleared
-      if (AllocInfo.Mapped) {
-        unmap(Ptr, AllocInfo.Size, MContext);
+    try {
+      for (auto &[Ptr, AllocInfo] : MAllocations) {
+        // Unmap allocations if required before physical memory is released
+        // Physical mem is released when MPhysicalMem is cleared
+        if (AllocInfo.Mapped) {
+          unmap(Ptr, AllocInfo.Size, MContext);
+        }
+        // Free the VA range
+        free_virtual_mem(reinterpret_cast<uintptr_t>(Ptr), AllocInfo.Size,
+                         MContext);
       }
-      // Free the VA range
-      free_virtual_mem(reinterpret_cast<uintptr_t>(Ptr), AllocInfo.Size,
-                       MContext);
+    } catch (std::exception &e) {
+      __SYCL_REPORT_EXCEPTION_TO_STREAM("exception in ~graph_mem_pool", e);
     }
     MPhysicalMem.clear();
   }
@@ -119,7 +124,7 @@ class graph_mem_pool {
             [&](sycl::handler &CGH) { CGH.memset(Ptr, 0, AllocInfo.Size); });
       }
 
-      MPhysicalMem.push_back(PhysicalMem);
+      MPhysicalMem.push_back(std::move(PhysicalMem));
       AllocInfo.PhysicalMemID = MPhysicalMem.size() - 1;
       AllocInfo.Mapped = true;
     }

sycl/source/detail/scheduler/commands.cpp

@@ -2558,7 +2558,7 @@ getCGKernelInfo(const CGExecKernel &CommandGroup, ContextImplPtr ContextImpl,
 }
 
 ur_result_t enqueueImpCommandBufferKernel(
-    context Ctx, device_impl &DeviceImpl,
+    const context &Ctx, device_impl &DeviceImpl,
     ur_exp_command_buffer_handle_t CommandBuffer,
     const CGExecKernel &CommandGroup,
     std::vector<ur_exp_command_buffer_sync_point_t> &SyncPoints,

sycl/source/detail/scheduler/commands.hpp

@@ -737,7 +737,7 @@ class UpdateCommandBufferCommand : public Command {
 
 // Enqueues a given kernel to a ur_exp_command_buffer_handle_t
 ur_result_t enqueueImpCommandBufferKernel(
-    context Ctx, device_impl &DeviceImpl,
+    const context &Ctx, device_impl &DeviceImpl,
     ur_exp_command_buffer_handle_t CommandBuffer,
     const CGExecKernel &CommandGroup,
     std::vector<ur_exp_command_buffer_sync_point_t> &SyncPoints,