[NVSHMEM] Added migration support for 65 unique nvSHMEM APIs#2791
Merged
Conversation
TejaX-Alaghari
changed the title
zhiweij1
reviewed
Apr 17, 2025
zhiweij1
reviewed
Apr 17, 2025
zhiweij1
reviewed
Apr 17, 2025
zhiweij1
reviewed
Apr 17, 2025
zhiweij1
reviewed
Apr 17, 2025
zhiweij1
approved these changes
Apr 17, 2025
|
|
||
| namespace dpct::shmem { | ||
|
|
||
| /// Setup Operations |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Setup Operations | |
| /// Setup Operations |
what end user can get from this ?
Contributor
Author
There was a problem hiding this comment.
Added these comments to serve as logical groupings of APIs for helper functions as there are many nvSHMEM APIs
As there are not many helper functions now, removed them
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef __DPCT_SHMEM_UTILS_HPP__ | ||
| #define __DPCT_SHMEM_UTILS_HPP__ |
Contributor
There was a problem hiding this comment.
no header file dependency for this header?
Contributor
Author
There was a problem hiding this comment.
nvshmem header file is migrated to ishmem, so no new dependency is added in this utils header file
TejaX-Alaghari
force-pushed
the
nvSHMEM
branch
3 times, most recently
from
c3dbb93 to
a217424
Compare
zhimingwang36
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds migration support for below new nvSHMEM APIs:
RMA
nvshmem_TYPE_put
nvshmem_TYPE_put_on_stream
nvshmem_TYPE_put_block
nvshmem_TYPE_put_warp
nvshmem_putSIZE
nvshmem_putSIZE_on_stream
nvshmem_putSIZE_block
nvshmem_putSIZE_warp
nvshmem_putmem
nvshmem_putmem_on_stream
nvshmem_putmem_block
nvshmem_putmem_warp
nvshmem_TYPE_p
nvshmem_TYPE_iput
nvshmem_TYPE_iput_on_stream
nvshmem_TYPE_iput_block
nvshmem_TYPE_iput_warp
nvshmem_iputSIZE
nvshmem_iputSIZE_on_stream
nvshmem_iputSIZE_block
nvshmem_iputSIZE_warp
nvshmem_TYPE_get
nvshmem_TYPE_get_on_stream
nvshmem_TYPE_get_block
nvshmem_TYPE_get_warp
nvshmem_getSIZE
nvshmem_getSIZE_block
nvshmem_getmem
nvshmem_getmem_block
nvshmem_TYPE_g
nvshmem_TYPE_iget
nvshmem_TYPE_iget_block
nvshmem_igetSIZE
nvshmem_igetSIZE_block
NBI RMA
nvshmem_TYPENAME_put_nbi
nvshmemx_TYPENAME_put_nbi_on_stream
nvshmemx_TYPENAME_put_nbi_block
nvshmemx_TYPENAME_put_nbi_warp
nvshmem_putSIZE_nbi
nvshmemx_putSIZE_nbi_on_stream
nvshmemx_putSIZE_nbi_block
nvshmemx_putSIZE_nbi_warp
nvshmem_putmem_nbi
nvshmemx_putmem_nbi_on_stream
nvshmemx_putmem_nbi_block
nvshmemx_putmem_nbi_warp
nvshmem_TYPENAME_get_nbi
nvshmemx_TYPENAME_get_nbi_on_stream
nvshmemx_TYPENAME_get_nbi_block
nvshmemx_TYPENAME_get_nbi_warp
nvshmem_getSIZE_nbi
nvshmemx_getSIZE_nbi_on_stream
nvshmemx_getSIZE_nbi_block
nvshmemx_getSIZE_nbi_warp
nvshmem_getmem_nbi
nvshmemx_getmem_nbi_on_stream
nvshmemx_getmem_nbi_block
nvshmemx_getmem_nbi_warp
Memory Ordering
Signaling Operations
Collective Operations