[SYCLomatic][Python Migration][Bug] Fix case_010_include_rule_file lit case#2861
Merged
Merged
Conversation
TejaX-Alaghari
changed the title
TejaX-Alaghari
force-pushed
the
py_mig_bug
branch
2 times, most recently
from
8baff5a to
413275b
Compare
zhiweij1
approved these changes
Jun 2, 2025
TejaX-Alaghari
force-pushed
the
py_mig_bug
branch
from
413275b to
dcaf676
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the flaky Python rule file inclusion bug which fails when including rule files
The root cause of this issue is due to using
llvm::StringRefobjects for tracking the processed YAML files in allvm::DensetSet.The contents of the
llvm::StringRefobjects change for each call toreadYAMLFile()function.And at times, the string data pointed by the
llvm::StringRefobjects stored in thellvm::DenseSetare altered unintentionally causing rule files to be skipped from including.This issue is fixed by using
std::unordered_set<std::string>in place ofllvm::DenseSet<llvm::StringRef>wherestd::stringobjects have the advantage of owning the memory of char array they store.