Update for review comments

-Remove verbage and boolean for optional stderr mirroring
-Replace fd 2 w/define

Signed-off-by: Russell McGuire <russell.w.mcguire@intel.com>

Author: rwmcguir

source/loader/ze_loader.cpp

@@ -25,11 +25,6 @@ namespace loader
     context_t *context;
 
     void context_t::debug_trace_message(std::string message, std::string result) {
-        if (zel_logger->log_to_console){
-            std::string debugTracePrefix = "ZE_LOADER_DEBUG_TRACE:";
-            std::cerr << debugTracePrefix << message << result << std::endl;
-        }
-
         zel_logger->log_trace(message + result);
     };
 
@@ -646,7 +641,6 @@ namespace loader
 
         if ((getenv_string("ZEL_LOADER_LOGGING_LEVEL") == "trace") && !debugTraceEnabled) {
             debugTraceEnabled = true;
-            zel_logger->log_to_console = false;
         }
 
         if (zel_logger->getLevel() != loader::LogLevel::off) {

source/utils/ze_logger.cpp

@@ -35,8 +35,8 @@ static bool winEnableAnsiColor(int fd) {
     if (!_isatty(fd)) {
         return false;
     }
-    HANDLE h = (fd == 2) ? GetStdHandle(STD_ERROR_HANDLE)
-                         : GetStdHandle(STD_OUTPUT_HANDLE);
+    HANDLE h = (fd == STDERR_FD) ? GetStdHandle(STD_ERROR_HANDLE)
+                               : GetStdHandle(STD_OUTPUT_HANDLE);
     if (h == INVALID_HANDLE_VALUE) {
         return false;
     }

source/utils/ze_logger.h

@@ -76,10 +76,6 @@ class ZeLogger {
     void log_fatal(const std::string &msg)        { critical(msg); }
     void log_performance(const std::string &msg)  { warn("[performance] " + msg); }
 
-    // When true, callers may mirror certain messages to stdout/stderr.
-    // Defaulted to true so init code can read it before explicitly disabling.
-    bool log_to_console = true;
-
 private:
     void write(LogLevel msg_level, const std::string &msg);
     void formatLine(LogLevel msg_level, const std::string &msg, std::string &out);