utils_rwlock_init fix

Author: lslusarczyk

src/provider/provider_level_zero.c

@@ -657,7 +657,7 @@ static umf_result_t ze_memory_provider_initialize(const void *params,
         }
     }
 
-    if (utils_rwlock_init(&ze_provider->resident_device_rwlock) == NULL) {
+    if (utils_rwlock_init(&ze_provider->resident_device_rwlock) != 0) {
         LOG_ERR("Cannot initialize resident device rwlock");
         umf_ba_global_free(ze_provider);
         return UMF_RESULT_ERROR_OUT_OF_RESOURCES;

src/utils/utils_concurrency.h

@@ -71,7 +71,7 @@ typedef struct utils_rwlock_t {
 #endif
 } utils_rwlock_t;
 
-utils_rwlock_t *utils_rwlock_init(utils_rwlock_t *ptr);
+int utils_rwlock_init(utils_rwlock_t *ptr);
 void utils_rwlock_destroy_not_free(utils_rwlock_t *rwlock);
 void utils_read_lock(utils_rwlock_t *rwlock);
 void utils_write_lock(utils_rwlock_t *rwlock);

src/utils/utils_posix_concurrency.c

@@ -46,10 +46,9 @@ void utils_init_once(UTIL_ONCE_FLAG *flag, void (*oneCb)(void)) {
     pthread_once(flag, oneCb);
 }
 
-utils_rwlock_t *utils_rwlock_init(utils_rwlock_t *ptr) {
+int utils_rwlock_init(utils_rwlock_t *ptr) {
     pthread_rwlock_t *rwlock = (pthread_rwlock_t *)ptr;
-    int ret = pthread_rwlock_init(rwlock, NULL);
-    return ret == 0 ? ((utils_rwlock_t *)rwlock) : NULL;
+    return pthread_rwlock_init(rwlock, NULL);
 }
 
 void utils_rwlock_destroy_not_free(utils_rwlock_t *ptr) {

src/utils/utils_windows_concurrency.c

@@ -36,7 +36,7 @@ int utils_mutex_unlock(utils_mutex_t *mutex) {
     return 0;
 }
 
-utils_rwlock_t *utils_rwlock_init(utils_rwlock_t *rwlock) {
+int utils_rwlock_init(utils_rwlock_t *rwlock) {
     InitializeSRWLock(&rwlock->lock);
     return 0; // never fails
 }