Skip to content

Commit 8dc8a3c

Browse files
[CI] zizmor fixes in benchmark's workflow
1 parent 55857fa commit 8dc8a3c

1 file changed

Lines changed: 18 additions & 8 deletions

File tree

.github/workflows/reusable_benchmarks.yml

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,23 +49,27 @@ jobs:
4949

5050
steps:
5151
- name: Establish bench params
52+
id: bench_params
5253
run: |
5354
params="${{ inputs.bench_script_params }}"
5455
if [ -n "${{ inputs.bench_script_compare }}" ]; then
5556
params="$params --compare '${{ inputs.bench_script_compare }}'"
5657
fi
5758
5859
echo "params=$params"
59-
echo "bench_params=$params" >> $GITHUB_ENV
60+
echo "PARAMS=$params" >> $GITHUB_OUTPUT
6061
6162
- name: Add comment to PR
6263
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
6364
if: ${{ always() && inputs.pr_no != 0 }}
65+
env:
66+
PR_NO: ${{ inputs.pr_no }}
67+
PARAMS: ${{ steps.bench_params.outputs.PARAMS }}
6468
with:
6569
script: |
66-
const pr_no = '${{ inputs.pr_no }}';
70+
const pr_no = '${PR_NO}';
6771
const url = '${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}';
68-
const params = `${{ env.bench_params }}`;
72+
const params = `${PARAMS}`;
6973
const body = `Compute Benchmarks run (with params: ${params}):\n${url}`;
7074
7175
github.rest.issues.createComment({
@@ -199,14 +203,15 @@ jobs:
199203
env:
200204
LD_LIBRARY_PATH: ${{ env.SYCL_DIR }}/lib
201205
CPATH: ${{ env.SYCL_DIR }}/include
206+
BENCH_PARAMS: ${{ steps.bench_params.outputs.PARAMS }}
202207
run: >
203208
taskset -c ${{ env.CORES }} ./sc/devops/scripts/benchmarks/main.py
204209
~/bench_workdir_umf
205210
--results-dir ${{ github.workspace }}/results-repo
206211
--output-markdown
207212
${{ (inputs.compatibility == 0) && format('--umf {0}/ --timeout 3000 --output-html remote', env.BUILD_DIR) || '' }}
208213
${{ (inputs.compatibility == 1) && format('--sycl {0} --timeout 7200', env.SYCL_DIR) || '' }}
209-
${{ env.bench_params }}
214+
${BENCH_PARAMS}
210215
211216
# In case it failed to add a comment, we can still print the results.
212217
- name: Print benchmark results
@@ -216,6 +221,11 @@ jobs:
216221
- name: Add comment to PR
217222
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0
218223
if: ${{ always() && inputs.pr_no != 0 }}
224+
env:
225+
PR_NO: ${{ inputs.pr_no }}
226+
BENCH_PARAMS: ${{ steps.bench_params.outputs.PARAMS }}
227+
BENCH_OUTCOME: ${{ steps.benchmarks.outcome }}
228+
JOB_STATUS: ${{ job.status }}
219229
with:
220230
script: |
221231
let markdown = ""
@@ -225,11 +235,11 @@ jobs:
225235
} catch(err) {
226236
}
227237
228-
const pr_no = '${{ inputs.pr_no }}';
238+
const pr_no = '$PR_NO';
229239
const url = '${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}';
230-
const test_status = '${{ steps.benchmarks.outcome }}';
231-
const job_status = '${{ job.status }}';
232-
const params = `${{ env.bench_params }}`;
240+
const test_status = '${BENCH_OUTCOME}';
241+
const job_status = '${JOB_STATUS}';
242+
const params = `${BENCH_PARAMS}`;
233243
const body = `Compute Benchmarks run (${params}):\n${url}\nJob status: ${job_status}. Test status: ${test_status}.\n ${markdown}`;
234244
235245
github.rest.issues.createComment({

0 commit comments

Comments
 (0)