Remove UMF_DISABLE_HWLOC option - #1228
Merged
Merged
Conversation
PatKamin
force-pushed
the
remove-disable-hwloc
branch
4 times, most recently
from
April 16, 2025 06:48
5229bc6 to
29de648
Compare
PatKamin
marked this pull request as ready for review
April 16, 2025 09:56
bratpiorka
reviewed
Apr 16, 2025
bratpiorka
reviewed
Apr 16, 2025
PatKamin
force-pushed
the
remove-disable-hwloc
branch
from
April 17, 2025 06:53
29de648 to
732af42
Compare
bratpiorka
approved these changes
Apr 17, 2025
lukaszstolarczuk
left a comment
lukaszstolarczuk
left a comment
Collaborator
There was a problem hiding this comment.
in general lgtm, but pls rebase
PatKamin
force-pushed
the
remove-disable-hwloc
branch
2 times, most recently
from
April 18, 2025 05:44
cf5ba95 to
939160c
Compare
KFilipek
approved these changes
May 6, 2025
KFilipek
left a comment
KFilipek
left a comment
Contributor
There was a problem hiding this comment.
I support this change with my whole heart.
Contributor
|
@PatKamin if you remove the "required" job, we will need to choose a new one - please ask @lukaszstolarczuk to do that |
lukaszstolarczuk
marked this pull request as draft
May 6, 2025 11:53
Collaborator
|
I'll change this to draft for now and merge when compiler's environment is ready (without it we couldn't do any updates to the compiler repo) |
lukaszstolarczuk
added a commit
to lukaszstolarczuk/unified-memory-framework
that referenced
this pull request
May 9, 2025
PatKamin
force-pushed
the
remove-disable-hwloc
branch
from
July 4, 2025 11:07
939160c to
7759255
Compare
PatKamin
marked this pull request as ready for review
July 4, 2025 11:24
PatKamin
force-pushed
the
remove-disable-hwloc
branch
2 times, most recently
from
July 7, 2025 15:35
7e8e968 to
d742ad9
Compare
PatKamin
force-pushed
the
remove-disable-hwloc
branch
from
July 7, 2025 16:22
d742ad9 to
ba470d1
Compare
lukaszstolarczuk
approved these changes
Jul 9, 2025
lukaszstolarczuk
marked this pull request as draft
July 10, 2025 12:27
Collaborator
|
Let's wait a little longer with merging this. Let's make sure everything else for 1.0.0 is working before we merge this ;) |
PatKamin
marked this pull request as ready for review
July 15, 2025 10:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After all third-party usage of the
UMF_DISABLE_HWLOCis removed, the flag itself can be removed. It was a temporary workaround for UMF usage without the hwloc installed in the system, from the beginning planned to be removed prior to the v1.0 first stable API release.Currently, UMF either uses libhwloc-dev installed in the system or fetches it from sources.
Fixes: #1047
Checklist