Skip to content

unify return values for destroy functions - #1356

Merged
lplewa merged 1 commit into
oneapi-src:mainfrom
lplewa:unify
Jun 11, 2025
Merged

unify return values for destroy functions#1356
lplewa merged 1 commit into
oneapi-src:mainfrom
lplewa:unify

Conversation

@lplewa

@lplewa lplewa commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

fixes: #1217

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used
  • All API changes are reflected in docs and def/map files, and are tested

@lplewa
lplewa requested a review from a team as a code owner June 5, 2025 12:11
bratpiorka
bratpiorka reviewed Jun 5, 2025
View reviewed changes
Comment thread src/memory_pool.c Outdated
bratpiorka
bratpiorka reviewed Jun 5, 2025
View reviewed changes
Comment thread src/memspace.c
bratpiorka
bratpiorka reviewed Jun 5, 2025
View reviewed changes
Comment thread src/pool/pool_scalable.c Outdated
bratpiorka
bratpiorka reviewed Jun 5, 2025
View reviewed changes
Comment thread src/provider/provider_file_memory.c Outdated
@lplewa
lplewa force-pushed the unify branch 4 times, most recently from 5d2f404 to 941f998 Compare June 10, 2025 09:19
lukaszstolarczuk
lukaszstolarczuk reviewed Jun 10, 2025
View reviewed changes

@lukaszstolarczuk lukaszstolarczuk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remember to open a draft PR in SYCL repo to update UMF usage there; can be done now or after the merge

Comment thread include/umf/memory_pool_ops.h
Comment thread include/umf/memory_provider_ops.h
Comment thread test/c_api/disjoint_pool.c
Comment thread src/memory_provider.c
ldorau
ldorau requested changes Jun 11, 2025
View reviewed changes
Comment thread src/memory_pool.c Outdated
@lplewa
lplewa merged commit 471f9bf into oneapi-src:main Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk left review comments
@ldorau ldorau ldorau approved these changes
@bratpiorka bratpiorka bratpiorka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unify return values for Destroy functions

4 participants

@lplewa @ldorau @bratpiorka @lukaszstolarczuk