From cb2efeaf481d5f9a0aac5c1125d6e31f07b9c77b Mon Sep 17 00:00:00 2001 From: Lukasz Dorau Date: Wed, 11 Jun 2025 14:37:47 +0200 Subject: [PATCH] Turn off UMF_DEVELOPER_MODE in CI Sanitizers jobs The UMF_DEVELOPER_MODE option turns on various additional debug checks that should be turned off in all Valgrind and Sanitizers builds, because we do not want to look for races in additional debug checks. Signed-off-by: Lukasz Dorau --- .github/workflows/reusable_sanitizers.yml | 4 ++-- .github/workflows/weekly.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/reusable_sanitizers.yml b/.github/workflows/reusable_sanitizers.yml index 133b8c1d1..5161f406c 100644 --- a/.github/workflows/reusable_sanitizers.yml +++ b/.github/workflows/reusable_sanitizers.yml @@ -53,7 +53,7 @@ jobs: -DUMF_BUILD_LEVEL_ZERO_PROVIDER=ON -DUMF_BUILD_CUDA_PROVIDER=ON -DUMF_FORMAT_CODE_STYLE=OFF - -DUMF_DEVELOPER_MODE=ON + -DUMF_DEVELOPER_MODE=OFF -DUMF_BUILD_LIBUMF_POOL_JEMALLOC=ON -DUMF_USE_ASAN=${{matrix.sanitizers.asan}} -DUMF_USE_UBSAN=${{matrix.sanitizers.ubsan}} @@ -125,7 +125,7 @@ jobs: -DCMAKE_PREFIX_PATH="${{env.VCPKG_PATH}}" -DUMF_BUILD_SHARED_LIBRARY=OFF -DUMF_FORMAT_CODE_STYLE=OFF - -DUMF_DEVELOPER_MODE=ON + -DUMF_DEVELOPER_MODE=OFF -DUMF_USE_ASAN=${{matrix.sanitizers.asan}} -DUMF_BUILD_EXAMPLES=ON -DUMF_BUILD_LEVEL_ZERO_PROVIDER=OFF diff --git a/.github/workflows/weekly.yml b/.github/workflows/weekly.yml index 71b4a07bd..fcaf8e913 100644 --- a/.github/workflows/weekly.yml +++ b/.github/workflows/weekly.yml @@ -54,7 +54,7 @@ jobs: -DUMF_BUILD_LEVEL_ZERO_PROVIDER=ON -DUMF_BUILD_CUDA_PROVIDER=ON -DUMF_FORMAT_CODE_STYLE=OFF - -DUMF_DEVELOPER_MODE=ON + -DUMF_DEVELOPER_MODE=OFF -DUMF_BUILD_LIBUMF_POOL_JEMALLOC=ON -DUMF_USE_ASAN=${{matrix.sanitizers.asan}} -DUMF_USE_UBSAN=${{matrix.sanitizers.ubsan}}