Turn off UMF_DEVELOPER_MODE in CI Sanitizers jobs - #1375
Merged
bratpiorka merged 1 commit intoJun 13, 2025
Merged
Conversation
The UMF_DEVELOPER_MODE option turns on various additional debug checks that should be turned off in all Valgrind and Sanitizers builds, because we do not want to look for races in additional debug checks. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
lukaszstolarczuk
approved these changes
Jun 12, 2025
Contributor
Are we? Imho If debug checks have bugs, if we enable them to debug something, we can start debug different issue. |
Contributor
Author
Yes, we do not want to check races between additional debug variables added by this option that do not exist in normal Release/Debug code when this option is turned off. |
Contributor
Author
|
@bratpiorka please review |
bratpiorka
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The UMF_DEVELOPER_MODE option turns on various additional debug checks that should be turned off in all Valgrind and Sanitizers builds, because we do not want to look for races in additional debug checks.
Checklist