Skip to content

add valgrind support in base allocator - #1389

Merged
bratpiorka merged 1 commit into
oneapi-src:mainfrom
lplewa:valgrind
Jul 2, 2025
Merged

add valgrind support in base allocator#1389
bratpiorka merged 1 commit into
oneapi-src:mainfrom
lplewa:valgrind

Conversation

@lplewa

@lplewa lplewa commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used
  • All API changes are reflected in docs and def/map files, and are tested

@lplewa
lplewa requested a review from a team as a code owner June 25, 2025 12:45
@ldorau

ldorau commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

Please fix memleaks found: https://github.com/oneapi-src/unified-memory-framework/actions/runs/15876704805/job/44778299595?pr=1389

bratpiorka
bratpiorka reviewed Jun 26, 2025
View reviewed changes
Comment thread src/base_alloc/base_alloc_linear.c
bratpiorka
bratpiorka reviewed Jun 26, 2025
View reviewed changes
Comment thread src/base_alloc/base_alloc_linear.c
bratpiorka
bratpiorka reviewed Jun 26, 2025
View reviewed changes
Comment thread test/supp/memcheck-test_coarse_lib.supp Outdated
@lplewa
lplewa force-pushed the valgrind branch 2 times, most recently from c5d3832 to f130387 Compare June 27, 2025 13:23
ldorau
ldorau requested changes Jun 30, 2025
View reviewed changes
Comment thread src/base_alloc/base_alloc_global.c
Comment thread src/base_alloc/base_alloc_global.c
@ldorau ldorau mentioned this pull request Jul 2, 2025
Merged
3 tasks
@ldorau
ldorau requested a review from bratpiorka July 2, 2025 08:28
@ldorau

ldorau commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

@bratpiorka re-review please

@bratpiorka
bratpiorka merged commit 5835cb8 into oneapi-src:main Jul 2, 2025
158 of 168 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldorau ldorau ldorau approved these changes
@bratpiorka bratpiorka bratpiorka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lplewa @ldorau @bratpiorka