Workaround build failure when building for jemalloc with ninja (#1474) - #1476
Merged
Conversation
bratpiorka
approved these changes
Aug 5, 2025
Contributor
|
@blenderfreaky UMF uses automatic code format checks, which are failing with your code. Note that the cmake-format package needs to be installed on your system |
ldorau
approved these changes
Aug 5, 2025
Contributor
Author
|
@bratpiorka thanks for the help! Rebased to fix the formatting issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue described in #1474
Description
The CMake code causing the issue now checks whether it's using ninja. If it is, it manually escapes the
$that it fails to escape on its own.Checklist