The last CTL patch :) - #1524
Merged
Merged
Conversation
lplewa
force-pushed
the
ctl_split
branch
11 times, most recently
from
September 18, 2025 14:44
629b379 to
2706166
Compare
Split between initialize and post-initialize function is necessary for properly handling CTL defaults.
lukaszstolarczuk
requested changes
Sep 19, 2025
lukaszstolarczuk
left a comment
lukaszstolarczuk
left a comment
Collaborator
There was a problem hiding this comment.
after all, this is super huge PR - I'd split this somehow, if easily done...
defaults changes global state, so using forks will isolate tests
lplewa
force-pushed
the
ctl_split
branch
2 times, most recently
from
September 19, 2025 14:44
94517a8 to
decb1fd
Compare
bratpiorka
requested changes
Oct 8, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates final CTL (Control Interface) changes for version 1.0, including error code adjustments and comprehensive implementation of CTL functionality for providers and pools. The CTL system provides a hierarchical interface for configuring and querying UMF components.
Key changes:
- Introduced new error code
UMF_RESULT_ERROR_INVALID_CTL_PATHfor invalid CTL paths - Added comprehensive CTL parameter support for disjoint pools with default overrides
- Enhanced provider and pool initialization with post-initialization hooks
- Added extensive test coverage and examples for CTL functionality
Reviewed Changes
Copilot reviewed 49 out of 49 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
include/umf/base.h |
Added new error code UMF_RESULT_ERROR_INVALID_CTL_PATH |
test/utils/cpp_helpers.hpp |
Updated default error return from UMF_RESULT_ERROR_UNKNOWN to UMF_RESULT_ERROR_INVALID_CTL_PATH |
test/pools/disjoint_pool_ctl.cpp |
Added comprehensive CTL tests for disjoint pool parameters and defaults |
test/pools/disjoint_pool.cpp |
Added post-initialization CTL calls to existing tests |
src/pool/pool_disjoint.c |
Implemented extensive CTL parameter support with read/write handlers |
src/memory_provider.c |
Added provider CTL defaults system and post-initialization support |
src/memory_pool.c |
Enhanced pool creation with CTL defaults and post-initialization |
examples/ctl/ |
Added comprehensive CTL usage examples |
KFilipek
requested changes
Oct 8, 2025
bratpiorka
approved these changes
Oct 10, 2025
KFilipek
approved these changes
Oct 10, 2025
lukaszstolarczuk
left a comment
lukaszstolarczuk
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, I mostly reviewed the docs.
1 issue left in my prev. comments - a typo.
Contributor
|
@lplewa ping :) |
lukaszstolarczuk
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.