do not call post_initialize on provider < 1.1 - #1540
Merged
Conversation
bratpiorka
marked this pull request as ready for review
October 29, 2025 11:34
bratpiorka
force-pushed
the
rrudnick_fix_post_init
branch
from
October 29, 2025 11:34
ad7f602 to
7f73757
Compare
bratpiorka
force-pushed
the
rrudnick_fix_post_init
branch
from
October 29, 2025 13:13
7f73757 to
e596a9d
Compare
lplewa
approved these changes
Oct 29, 2025
lplewa
left a comment
lplewa
left a comment
Contributor
There was a problem hiding this comment.
NIT: Comment and error log is misleading/incorrect.
"Non supported" is wrong word. This CTL call was just not existing, also we require return error INVALID_CTL_PATH for non supported calls since 1.1 version, so 1.0 ctl implementation returns not standardized error code for unknown ctl path (invalid argument, unsupported, or even i can imagine returning a success)
Word "Supported" indicate that it something that we support, while in this case we talk about custom providers not provided by UMF, which do not know this call, and returns error code, which we do not expect for a reason that i wrote above.
bratpiorka
force-pushed
the
rrudnick_fix_post_init
branch
from
October 30, 2025 08:46
e596a9d to
b273986
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do not call post_initialize on provider < 1.1
this fixes nightly build:
https://github.com/oneapi-src/unified-memory-framework/actions/runs/18906308402/job/53965309976?pr=1540