Skip to content

Implement size limit for the cache of opened IPC handles - #998

Merged
bratpiorka merged 6 commits into
oneapi-src:mainfrom
vinser52:svinogra_ipc_cache
Mar 11, 2025
Merged

Implement size limit for the cache of opened IPC handles#998
bratpiorka merged 6 commits into
oneapi-src:mainfrom
vinser52:svinogra_ipc_cache

Conversation

@vinser52

@vinser52 vinser52 commented Dec 17, 2024 •
edited
Loading

Copy link
Copy Markdown

Description

It is a follow-up of the #736. Add an environment variable that allows setting a limit for the size of the cache of opened IPC handles.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • New tests added, especially if they will fail without my changes
  • Extended the README/documentation

@vinser52

vinser52 commented Dec 17, 2024

Copy link
Copy Markdown
Author

TODO: need to add tests

@lukaszstolarczuk

lukaszstolarczuk commented Dec 17, 2024

Copy link
Copy Markdown
Collaborator

and probably you could add some info about this var into README, pls

@vinser52

vinser52 commented Dec 17, 2024

Copy link
Copy Markdown
Author

and probably you could add some info about this var into README, pls

Sure, I will do that.

@vinser52 vinser52 mentioned this pull request Dec 17, 2024
Closed
@bratpiorka bratpiorka added this to the v0.11.x milestone Jan 3, 2025
@bratpiorka

bratpiorka commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

@vinser52 what are the plans for this PR? Is it working and ready to review?

@vinser52

vinser52 commented Feb 17, 2025

Copy link
Copy Markdown
Author

@vinser52 what are the plans for this PR? Is it working and ready to review?

It is not ready yet. I am working on it right now. Need to implement proper refcounting and eviction.

@vinser52 vinser52 mentioned this pull request Feb 17, 2025
Merged
3 tasks
@vinser52
vinser52 force-pushed the svinogra_ipc_cache branch 4 times, most recently from 00e4b48 to f6b00ec Compare February 21, 2025 11:31
@vinser52
vinser52 marked this pull request as ready for review February 21, 2025 11:32
@vinser52
vinser52 requested a review from a team as a code owner February 21, 2025 11:32
vinser52
vinser52 commented Feb 21, 2025
View reviewed changes
Comment thread test/ipcFixtures.hpp
@vinser52

vinser52 commented Feb 21, 2025

Copy link
Copy Markdown
Author

and probably you could add some info about this var into README, pls

@lukaszstolarczuk Done. I updated the online documentation.

@vinser52
vinser52 requested review from igchor, ldorau and lplewa February 21, 2025 20:52
@vinser52
vinser52 force-pushed the svinogra_ipc_cache branch 2 times, most recently from abe2ff4 to aa8c457 Compare February 22, 2025 21:28
ldorau
ldorau reviewed Feb 24, 2025
View reviewed changes
Comment thread .github/workflows/reusable_compatibility.yml Outdated
Comment thread docs/config/api.rst
ldorau
ldorau requested changes Feb 24, 2025
View reviewed changes
Comment thread src/ipc_cache.c
Comment thread test/ipcFixtures.hpp
Comment thread .github/workflows/reusable_compatibility.yml Outdated
ldorau
ldorau requested changes Feb 24, 2025
View reviewed changes
Comment thread src/provider/provider_tracking.c
Comment thread src/provider/provider_tracking.c
@vinser52
vinser52 force-pushed the svinogra_ipc_cache branch 3 times, most recently from 4f58542 to 11c7f6d Compare March 5, 2025 19:47
ldorau
ldorau requested changes Mar 6, 2025
View reviewed changes
Comment thread src/provider/provider_tracking.c
ldorau

This comment was marked as outdated.

Sign in to view

ldorau
ldorau approved these changes Mar 6, 2025
View reviewed changes

@ldorau ldorau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the above question

@vinser52
vinser52 force-pushed the svinogra_ipc_cache branch from 11c7f6d to 583973d Compare March 7, 2025 11:08
bratpiorka
bratpiorka reviewed Mar 7, 2025
View reviewed changes
Comment thread .github/workflows/reusable_compatibility.yml
bratpiorka
bratpiorka reviewed Mar 7, 2025
View reviewed changes
Comment thread test/CMakeLists.txt Outdated
bratpiorka
bratpiorka reviewed Mar 7, 2025
View reviewed changes
Comment thread src/provider/provider_tracking.c Outdated
@vinser52
vinser52 force-pushed the svinogra_ipc_cache branch from 583973d to 89d338c Compare March 7, 2025 15:45
@ldorau
ldorau requested a review from bratpiorka March 10, 2025 08:36
@vinser52 vinser52 mentioned this pull request Mar 10, 2025
Merged
5 tasks
@ldorau ldorau mentioned this pull request Mar 10, 2025
Merged
3 tasks
@vinser52
vinser52 force-pushed the svinogra_ipc_cache branch from 89d338c to f072239 Compare March 10, 2025 11:19
@ldorau

ldorau commented Mar 10, 2025

Copy link
Copy Markdown
Contributor

@bratpiorka @lplewa @igchor please re-review

KFilipek
KFilipek reviewed Mar 10, 2025
View reviewed changes
Comment thread test/CMakeLists.txt
@ldorau

ldorau commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

@vinser52 please rebase

@vinser52
vinser52 force-pushed the svinogra_ipc_cache branch from f072239 to 5f4336d Compare March 11, 2025 11:45
@vinser52

vinser52 commented Mar 11, 2025

Copy link
Copy Markdown
Author

@vinser52 please rebase

Done

@bratpiorka
bratpiorka merged commit 785c710 into oneapi-src:main Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldorau ldorau ldorau approved these changes
@KFilipek KFilipek KFilipek approved these changes
@bratpiorka bratpiorka bratpiorka approved these changes
@lplewa lplewa Awaiting requested review from lplewa
+1 more reviewer
@igchor igchor igchor approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.11.x

Development

Successfully merging this pull request may close these issues.

6 participants

@vinser52 @lukaszstolarczuk @bratpiorka @ldorau @KFilipek @igchor