rewrite github related code (#738)

Rewrite the entirety of GitHub issue/pull handling code.

closes GH-571
closes GH-320
closes GH-564
closes GH-564

Key refactors:
- use a renderer system for each type of resource having a class based
renderer, rather than a whole bunch of Ifs
- centralized configuration for all behavioral changes by any
configuration or feature set
- standardized behavior
- removal of the show more/less button, replaced with the show more
button which shows a modal rather than more contents
- smaller limits on the size of the embed
- proper mixing of different types, such as a link and shorthand in the
same message
- properly follow and display source repository when an issue/discussion
has been transferred to a different repository
- mirror the emoji colors to the embed colour
- when displaying comments, use the same coloured embeds that Discord
webhooks use.
- provide the correct html_url for mannequin users
- provide the correct username/login for mannequin users on comment
embeds

---------

Signed-off-by: Zenith <me@arielle.codes>
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>

Author: onerandomusername

docs/commands/app-commands.md

@@ -246,16 +246,16 @@ bots.
 
 Fetches info from GitHub.
 
-### `github`
+### `github info`
 
-- `arg` (`string`) (required) Can be a org/repo#number, a link to an issue or
-    issue comment, and more.
+- `arg` (`string`) (required) The GitHub resource to view . Can be a URL or
+    shorthand like owner/repo#issue_number.
 
-View information about an issue, pull, discussion, or comment on GitHub.
+Fetch GitHub information.
 
 **Usable in:** `Guilds`, `Bot DMs`, `Private Channels`
 
-**Installable as:** `Guild`
+**Installable as:** `Guild`, `User`
 
 ## Guild Config
 

docs/commands/prefix-commands.md

@@ -141,29 +141,21 @@ Management commands for bot features.
 
 Fetches info from GitHub.
 
-### `github [user_or_repo=]`
+### `github [args...]`
 
-*Commands for finding information related to GitHub.*
+*Group for GitHub related commands.*
 
-**Can also use:** `gh`, `git`
+**Can also use:** `gh`
 
-### `github issue <numbers> <repo> [user=None]`
+### `github repo <user_and_repo> [repo=]`
 
-*Command to retrieve issue(s) from a GitHub repository.*
+*Fetch GitHub repository information.*
 
-**Can also use:** `github pr`, `github pull`
+**Can also use:** `github repo_info`, `github repository`
 
-### `github repository [repository...]`
+### `github user <user>`
 
-*Fetches a repositories' GitHub information.*
-
-**Can also use:** `github repo`, `repo`
-
-### `github user <username>`
-
-*Fetches a user's GitHub information.*
-
-**Can also use:** `github userinfo`
+*Fetch GitHub user information.*
 
 ## Help
 

monty/constants.py

@@ -240,6 +240,10 @@ class GHColour(int, enum.Enum):
     attention = 0x9A6700
     default = 0x1F2328
 
+    # These are used by Discord
+    issue_comment = 0xE68D60
+    pull_comment = 0xBFE5BF
+
 
 ## DEPRECATED
 # TODO: Will be replaced in favour of application emojis
@@ -329,6 +333,11 @@ class AppEmojisCls(BaseModel, arbitrary_types_allowed=True):
         file_name="discussion-closed",
         color=GHColour.done,
     )
+    discussion_closed_unresolved: AppEmojiAnn = Octicon(
+        name="gh-discussion-closed-unresolved",
+        file_name="comment-discussion",
+        color=GHColour.muted,
+    )
     discussion_outdated: AppEmojiAnn = Octicon(
         name="gh-discussion-outdated",
         file_name="discussion-outdated",
@@ -349,8 +358,18 @@ class AppEmojisCls(BaseModel, arbitrary_types_allowed=True):
         file_name="issue-closed",
         color=GHColour.done,
     )
+    issue_closed_generic: AppEmojiAnn = Octicon(
+        name="gh-skip",
+        file_name="skip",
+        color=GHColour.muted,
+    )
     issue_closed_unplanned: AppEmojiAnn = Octicon(
-        name="gh-issue-closed-unplanned",
+        name="gh-skip",
+        file_name="skip",
+        color=GHColour.muted,
+    )
+    issue_closed_duplicate: AppEmojiAnn = Octicon(
+        name="gh-skip",
         file_name="skip",
         color=GHColour.muted,
     )
@@ -395,9 +414,14 @@ class Feature(enum.Enum):
     DISCORD_TOKEN_REMOVER = "DISCORD_BOT_TOKEN_FILTER"  # noqa: S105
     DISCORD_WEBHOOK_REMOVER = "DISCORD_WEBHOOK_FILTER"
     GITHUB_COMMENT_LINKS = "GITHUB_EXPAND_COMMENT_LINKS"
+    "Controls whether or not GitHub comment links are expanded into embeds. Requires GITHUB_ISSUE_LINKS to be enabled."
     GITHUB_DISCUSSIONS = "GITHUB_AUTOLINK_DISCUSSIONS"
-    GITHUB_ISSUE_EXPAND = "GITHUB_AUTOLINK_ISSUE_SHOW_DESCRIPTION"
+    "Controls whether or not GitHub Discussions are automatically linked. Requires GITHUB_ISSUE_LINKS to be enabled."
     GITHUB_ISSUE_LINKS = "GITHUB_EXPAND_ISSUE_LINKS"
+    "Controls whether or not GitHub embeds are replaced with Monty's Embeds."
+    # Deprecated, NO-OP
+    GITHUB_ISSUE_EXPAND = "GITHUB_AUTOLINK_ISSUE_SHOW_DESCRIPTION"
+    "Controls whether or not GitHub Embeds are expanded to show more information. Requires GITHUB_ISSUE_LINKS."
     GLOBAL_SOURCE = "GLOBAL_SOURCE_COMMAND"
     INLINE_DOCS = "INLINE_DOCUMENTATION"
     INLINE_EVALULATION = "INLINE_EVALULATION"

monty/exts/info/github/__init__.py

@@ -0,0 +1,12 @@
+from .cog import GithubInfo
+
+
+TYPE_CHECKING = 0
+
+if TYPE_CHECKING:
+    from monty.bot import Monty
+
+
+def setup(bot: "Monty") -> None:
+    """Setup the Github Info cog."""
+    bot.add_cog(GithubInfo(bot))