typing: use ctx.app_permissions where possible (#752)

Author: onerandomusername

monty/exts/core/error_handler.py

@@ -143,7 +143,7 @@ async def send_error(self, ctx: AnyContext, content: str | None = None, **kwargs
         )
         if isinstance(ctx, commands.Context):
             components.insert_item(0, DeleteButton(ctx.author, initial_message=ctx.message))
-            app_permissions = ctx.channel.permissions_for(ctx.me)  # pyright: ignore[reportArgumentType]
+            app_permissions = ctx.app_permissions
             if app_permissions.manage_messages:
                 send_error = functools.partial(
                     ctx.reply,
@@ -223,13 +223,9 @@ async def handle_bot_missing_perms(
     ) -> None:
         """Handles bot missing permissing by dming the user if they have a permission which may be able to fix this."""
         embed = self.error_embed("Permissions Failure", str(error))
-        if isinstance(ctx, commands.Context):
-            app_permissions = ctx.channel.permissions_for(ctx.me)  # pyright: ignore[reportArgumentType]
-        else:
-            app_permissions = ctx.app_permissions
-        if app_permissions >= disnake.Permissions(send_messages=True, embed_links=True):
+        if ctx.app_permissions >= disnake.Permissions(send_messages=True, embed_links=True):
             await self.send_error(ctx, embeds=[embed])
-        elif app_permissions >= disnake.Permissions(send_messages=True):
+        elif ctx.app_permissions >= disnake.Permissions(send_messages=True):
             # make a message as similar to the embed, using as few permissions as possible
             # this is the only place we send a standard message instead of an embed
             # so no helper methods are necessary

monty/exts/core/eval.py

@@ -336,7 +336,7 @@ async def ieval(self, ctx: commands.Context, *, body: str) -> None:
         if not response.components and not response.files:
             return
 
-        if ctx.guild is not None and ctx.channel.permissions_for(ctx.guild.me).manage_messages:
+        if ctx.app_permissions.manage_messages:
             delete_contexts = (ctx.message, None)
         else:
             delete_contexts = (None,)
@@ -432,7 +432,7 @@ async def repl(self, ctx: commands.Context) -> None:
                 if not response.components and not response.files:
                     continue
 
-                if msg.guild is not None and msg.channel.permissions_for(msg.guild.me).manage_messages:
+                if ctx.app_permissions.manage_messages:
                     delete_contexts = (msg, None)
                 else:
                     delete_contexts = (None,)

monty/exts/core/gateway.py

@@ -52,9 +52,7 @@ async def gateway(self, ctx: commands.Context) -> None:
             DeleteButton(
                 ctx.author.id,
                 allow_manage_messages=False,
-                initial_message=(
-                    ctx.message if ctx.guild and ctx.channel.permissions_for(ctx.guild.me).manage_messages else None
-                ),
+                initial_message=(ctx.message if ctx.app_permissions.manage_messages else None),
             ),
         ]
         await ctx.send(components=components, allowed_mentions=disnake.AllowedMentions.none())

monty/exts/python/eval.py

@@ -321,8 +321,7 @@ async def continue_eval(self, ctx: commands.Context, response: disnake.Message)
                 pass
 
             # if we have permissions, delete the user's reaction
-            app_permissions = ctx.channel.permissions_for(ctx.me)  # type: ignore
-            if app_permissions.manage_messages:
+            if ctx.app_permissions.manage_messages:
                 try:
                     await ctx.message.clear_reaction(REEVAL_EMOJI)
                 except disnake.Forbidden:

monty/exts/utils/bookmark.py

@@ -183,8 +183,7 @@ async def send_embed(
         ]
         kwargs = {}
         if isinstance(ctx, commands.Context):
-            app_permissions = ctx.channel.permissions_for(ctx.me)  # type: ignore
-            if ctx.channel == target_message.channel and app_permissions.read_message_history:
+            if ctx.channel == target_message.channel and ctx.app_permissions.read_message_history:
                 kwargs["reference"] = target_message.to_reference(fail_if_not_exists=False)
 
             allowed_mentions = disnake.AllowedMentions.none()
@@ -278,7 +277,7 @@ async def _bookmark(
             if isinstance(ctx, disnake.Interaction):
                 await ctx.send(embed=result, ephemeral=True)
             else:
-                app_permissions = ctx.channel.permissions_for(ctx.me)  # type: ignore
+                app_permissions = ctx.app_permissions
                 if app_permissions.read_message_history:
                     components = DeleteButton(ctx.author, initial_message=ctx.message)
                     await ctx.reply(embed=result, fail_if_not_exists=False, components=components)