Merge pull request #315 from onflow/bastian/improve-round-up

turbolent · web-flow · commit 68cff90aa859 · 2026-04-09T15:09:23.000-07:00
Improve FlowALPMath.roundUp
diff --git a/cadence/lib/FlowALPMath.cdc b/cadence/lib/FlowALPMath.cdc
@@ -83,8 +83,7 @@ access(all) contract FlowALPMath {
     }
 
     access(self) view fun roundUp(_ base: UFix64): UFix64 {
-        let increment: UFix64 = 0.00000001
-        return base >= UFix64.max - increment ? UFix64.max : base + increment
+        return base.saturatingAdd(0.00000001)
     }
 
     access(self) view fun roundHalfToEven(_ base: UFix64, _ remainder: UFix128): UFix64 {

Original file line number	Diff line number	Diff line change
`@@ -83,8 +83,7 @@ access(all) contract FlowALPMath {`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`access(self) view fun roundUp(_ base: UFix64): UFix64 {`
`86`		`- let increment: UFix64 = 0.00000001`
`87`		`- return base >= UFix64.max - increment ? UFix64.max : base + increment`
	`86`	`+ return base.saturatingAdd(0.00000001)`
`88`	`87`	`}`
`89`	`88`
`90`	`89`	`access(self) view fun roundHalfToEven(_ base: UFix64, _ remainder: UFix128): UFix64 {`